Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: trunk/src/chrome/browser/ui/tabs/tab_strip_model.cc

Issue 192913002: Revert 253735 "Always broadcast one last "tab not blocked" notif..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/ui/tabs/tab_strip_model.cc
===================================================================
--- trunk/src/chrome/browser/ui/tabs/tab_strip_model.cc (revision 255951)
+++ trunk/src/chrome/browser/ui/tabs/tab_strip_model.cc (working copy)
@@ -1250,12 +1250,6 @@
void TabStripModel::InternalCloseTab(WebContents* contents,
int index,
bool create_historical_tabs) {
- // Reset the blocked state of the tab, and fire a notification if necessary.
- // <http://crbug.com/336386#c4> . TODO(avi): Remove all the "blocked" code and
- // the WebContentsModalDialogManager from TabStripModel, and move all that
- // tracking code to the modal dialog code, where it belongs.
- SetTabBlocked(index, false);
-
FOR_EACH_OBSERVER(TabStripModelObserver, observers_,
TabClosingAt(this, contents, index));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698