Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1929123002: Add checks for detached ArrayBuffers to ArrayBuffer.prototype.slice (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add checks for detached ArrayBuffers to ArrayBuffer.prototype.slice These checks ensure that a TypeError is thrown, per spec, rather than a runtime assert failure. BUG=v8:4964 R=adamk LOG=Y Committed: https://crrev.com/3d66e5d1d762af279eecdbd1c11463fed0bbd4a7 Cr-Commit-Position: refs/heads/master@{#35885}

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -17 lines) Patch
M src/js/arraybuffer.js View 1 chunk +3 lines, -1 line 0 comments Download
M src/messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/IfConditions.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-353004.js View 1 1 chunk +12 lines, -10 lines 0 comments Download
A test/mjsunit/regress/regress-4964.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929123002/1
4 years, 7 months ago (2016-04-28 21:29:19 UTC) #2
Dan Ehrenberg
4 years, 7 months ago (2016-04-28 21:29:24 UTC) #3
adamk
lgtm
4 years, 7 months ago (2016-04-28 21:31:09 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/913) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 7 months ago (2016-04-28 21:44:44 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929123002/20001
4 years, 7 months ago (2016-04-28 22:03:02 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 22:38:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929123002/20001
4 years, 7 months ago (2016-04-28 22:47:31 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 22:49:49 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:09 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d66e5d1d762af279eecdbd1c11463fed0bbd4a7
Cr-Commit-Position: refs/heads/master@{#35885}

Powered by Google App Engine
This is Rietveld 408576698