Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1929113002: [Mac/GN] Define a GN file for all the XIB files. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
erikchen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Define a GN file for all the XIB files. BUG=431177 R=erikchen@chromium.org Committed: https://crrev.com/ebf0e263584b9e1b04e174443373fc9d6d4a4954 Cr-Commit-Position: refs/heads/master@{#390490}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove dupe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
A chrome/app/nibs/BUILD.gn View 1 chunk +55 lines, -0 lines 0 comments Download
M chrome/chrome_nibs.gypi View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Robert Sesek
4 years, 7 months ago (2016-04-28 19:58:56 UTC) #1
erikchen
lgtm https://codereview.chromium.org/1929113002/diff/1/chrome/chrome_nibs.gypi File chrome/chrome_nibs.gypi (right): https://codereview.chromium.org/1929113002/diff/1/chrome/chrome_nibs.gypi#newcode43 chrome/chrome_nibs.gypi:43: 'app/nibs/HungRendererDialog.xib', This nib shows up in mac_untranslated_xibs as ...
4 years, 7 months ago (2016-04-28 20:04:41 UTC) #2
Robert Sesek
https://codereview.chromium.org/1929113002/diff/1/chrome/chrome_nibs.gypi File chrome/chrome_nibs.gypi (right): https://codereview.chromium.org/1929113002/diff/1/chrome/chrome_nibs.gypi#newcode43 chrome/chrome_nibs.gypi:43: 'app/nibs/HungRendererDialog.xib', On 2016/04/28 20:04:41, erikchen wrote: > This nib ...
4 years, 7 months ago (2016-04-28 20:09:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929113002/20001
4 years, 7 months ago (2016-04-28 20:10:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 21:35:50 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:21:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebf0e263584b9e1b04e174443373fc9d6d4a4954
Cr-Commit-Position: refs/heads/master@{#390490}

Powered by Google App Engine
This is Rietveld 408576698