lib/vm_service_client.dart - Issue 1929063002: pkg/vm_service_client: add getSourceReport to VMServiceReference

Unified Diff: lib/vm_service_client.dart

Issue 1929063002: pkg/vm_service_client: add getSourceReport to VMServiceReference (Closed) Base URL: https://github.com/dart-lang/vm_service_client.git@master

Patch Set: nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/vm_service_client.dart

diff --git a/lib/vm_service_client.dart b/lib/vm_service_client.dart

index f9062cef55caf96c9c6aaa104ddf881d58c583ba..5c9bb3bda461268e48143f077401384a628a994a 100644

--- a/lib/vm_service_client.dart

+++ b/lib/vm_service_client.dart

@@ -37,10 +37,13 @@ export 'src/library.dart' hide newVMLibraryRef;

export 'src/message.dart' hide newVMMessage;

export 'src/object.dart';

export 'src/pause_event.dart' hide newVMPauseEvent;

-export 'src/script.dart' hide newVMScriptRef, newVMScriptToken;

+export 'src/script.dart' hide newVMScriptRef, newVMScriptToken,

+ newVMScriptTokenFromPosition;

export 'src/sentinel.dart' hide newVMSentinel;

export 'src/service_version.dart' hide newVMServiceVersion;

-export 'src/source_location.dart' hide newVMSourceLocation;

+export 'src/source_location.dart' hide newVMSourceLocation,

+ newVMSourceLocationFromPosition;

+export 'src/source_report.dart' hide newSourceReport;

export 'src/stack.dart' hide newVMStack;

export 'src/type_arguments.dart' hide newVMTypeArgumentsRef;

export 'src/unresolved_source_location.dart' hide newVMUnresolvedSourceLocation;

@@ -126,7 +129,7 @@ class VMServiceClient {

///

/// This is useful when using the client over a pre-existing connection. To

/// establish a connection from scratch, use [connect].

- factory VMServiceClient(StreamChannel<String> channel) =>

+ factory VMServiceClient(StreamChannel<Object> channel) =>

kevmoo 2016/05/17 22:12:01 This was blowing up with the latest strong-clean p

nweiz 2016/05/19 21:11:13 This should definitely take a StreamChannel<String

kevmoo 2016/05/19 21:59:46 INFO: The argument type 'JsonDocumentTransformer'

nweiz 2016/05/19 22:47:15 Hmm, this might actually be a StreamChannel bug. U

kevmoo 2016/05/19 23:39:36 Done.

new VMServiceClient.withoutJson(channel.transform(jsonDocument));

/// Creates a client that reads incoming decoded messages from [incoming] and

« lib/src/script.dart ('K') | « lib/src/source_report.dart ('k') | pubspec.yaml » ('j') | test/source_report_test.dart » ('J')