pkg/vm_service_client: add getSourceReport to VMServiceReference

lib/src/script.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:math' as math;
 
 import 'package:json_rpc_2/json_rpc_2.dart' as rpc;
 import 'package:source_span/source_span.dart';
 
 import 'breakpoint.dart';
 import 'class.dart';
 import 'library.dart';
 import 'object.dart';
 import 'scope.dart';
 import 'source_location.dart';
+import 'source_report.dart';
 
 VMScriptRef newVMScriptRef(Scope scope, Map json) {
   if (json == null) return null;
   assert(json["type"] == "@Script" || json["type"] == "Script");
   return new VMScriptRef._(scope, json);
 }
 
 VMScriptToken newVMScriptToken(String isolateId, String scriptId,
         int position) {
   if (position == null) return null;
   return new VMScriptToken._(isolateId, scriptId, position);
 }
 
+VMScriptToken newVMScriptTokenFromScript(VMScriptRef script, int position) {

[nweiz, 2016/05/04 23:05:51]

I think I'd call this "from position" rather than "from script".

[kevmoo, 2016/05/05 20:46:26]

Done.

+  if (position == null) return null;
+  return new VMScriptToken._(script._scope.isolateId, script._id, position);
+}
+
 /// A reference to a script in the Dart VM.
 ///
 /// A script contains information about the actual text of a library. Usually
 /// there's only one script per library, but the `part` directive can produce
 /// libraries made up of multiple scripts.
 class VMScriptRef implements VMObjectRef {
   final Scope _scope;
 
   /// The ID for script library, which is unique relative to its isolate.
   final String _id;
@@ skipping 23 matching lines @@
     try {
       var response = await _scope.sendRequest("addBreakpoint", params);
       return newVMBreakpoint(_scope, response);
     } on rpc.RpcException catch (error) {
       // Error 102 indicates that the breakpoint couldn't be created.
       if (error.code == 102) return null;
       rethrow;
     }
   }
 
+  /// Generates a set of reports tied to this script.
+  ///
+  /// If [includeCoverageReport] is `true`, the report includes code coverage
+  /// information via [VMSourceReportRange.coverage] in
+  /// [VMSourceReport.ranges].
+  /// Otherwise, [VMSourceReportRange.coverage] is `null`.
+  ///
+  /// If [includePossibleBreakpoints] is `true`, the report includes a list of
+  /// token positions which correspond to possible breakpoints via
+  /// [VMSourceReportRange.possibleBreakpoints] in [VMSourceReport.ranges].
+  /// Otherwise, [VMSourceReportRange.possibleBreakpoints] is `null`.
+  ///
+  /// If [forceCompile] is `true`, all functions in the range of the report
+  /// will be compiled. If `false`, functions that are never used may not appear
+  /// in [VMSourceReportRange.misses].
+  /// Forcing compilation can cause a compilation error, which could terminate
+  /// the running Dart program.
+  ///
+  /// Either or both [start] and [end] may be provided to restrict the analysis
+  /// to a subrange of a script.

[nweiz, 2016/05/04 23:05:51]

What does it mean to pass only "start" or only "end"?

[kevmoo, 2016/05/05 20:46:26]

I think I cleared it up

+  /// For example, these can be used to restrict the report to the range of a
+  /// particular class or function.
+  Future<VMSourceReport> getSourceReport(
+      {bool includeCoverageReport: false,
+      bool includePossibleBreakpoints: false,
+      bool forceCompile: false,
+      VMScriptToken start,
+      VMScriptToken end}) async {
+    var reports = <String>[];
+    if (includeCoverageReport) {
+      reports.add('Coverage');
+    }
+    if (includePossibleBreakpoints) {
+      reports.add('PossibleBreakpoints');
+    }
+
+    var params = <String, dynamic>{'scriptId': _id, 'reports': reports};
+    if (forceCompile) {
+      params['forceCompile'] = true;

[nweiz, 2016/05/04 23:05:51]

Nit: put the results on the same line as the "if" if it'll all fit on the same
line.

[kevmoo, 2016/05/05 20:46:26]

Acknowledged.

+    }
+    if (start != null) {
+      params['tokenPos'] = start._position;
+    }
+    if (end != null) {
+      params['endTokenPos'] = end._position;
+    }
+
+    var json = await _scope.sendRequest('getSourceReport', params);
+    return newSourceReport(_scope, json);
+  }
+
   bool operator ==(other) => other is VMScriptRef &&
       (_fixedId ? _id == other._id : super == other);
 
   int get hashCode => _fixedId ? _id.hashCode : super.hashCode;
 
   String toString() => uri.toString();
 }
 
 /// A script in the Dart VM.
 class VMScript extends VMScriptRef implements VMObject {
@@ skipping 277 matching lines @@
       return new _ScriptSpan(_script, startPosition, endPosition,
           startPosition == this._startPosition ? this._start : other._start,
           endPosition == this._endPosition ? this._end : other._end);
     } else {
       var start = math.min(this.start.offset, other.start.offset);
       var end = math.max(this.end.offset, other.end.offset);
       return file.span(start, end);
     }
   }
 }