Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1810)

Unified Diff: ash/metrics/user_metrics_recorder.cc

Issue 1929023002: Refactors WindowResizers to use ash/wm/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/metrics/user_metrics_recorder.cc
diff --git a/ash/metrics/user_metrics_recorder.cc b/ash/metrics/user_metrics_recorder.cc
index cadf710158ad7fcd9e967afc956743fa1565b39d..e07afe8290b86591d64a32315b2ea26422277f4a 100644
--- a/ash/metrics/user_metrics_recorder.cc
+++ b/ash/metrics/user_metrics_recorder.cc
@@ -15,6 +15,7 @@
#include "ash/shell_window_ids.h"
#include "ash/system/tray/system_tray_delegate.h"
#include "ash/wm/common/window_state.h"
+#include "ash/wm/common/wm_user_metrics_action.h"
#include "ash/wm/window_state_aura.h"
#include "base/metrics/histogram.h"
#include "base/metrics/user_metrics.h"
@@ -242,12 +243,6 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {
task_switch_metrics_recorder_.OnTaskSwitch(
TaskSwitchMetricsRecorder::DESKTOP);
break;
- case ash::UMA_DRAG_MAXIMIZE_LEFT:
- base::RecordAction(base::UserMetricsAction("WindowDrag_MaximizeLeft"));
- break;
- case ash::UMA_DRAG_MAXIMIZE_RIGHT:
- base::RecordAction(base::UserMetricsAction("WindowDrag_MaximizeRight"));
- break;
case ash::UMA_LAUNCHER_BUTTON_PRESSED_WITH_MOUSE:
base::RecordAction(
base::UserMetricsAction("Launcher_ButtonPressed_Mouse"));
@@ -608,6 +603,18 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {
}
}
+void UserMetricsRecorder::RecordUserMetricsAction(
+ wm::WmUserMetricsAction action) {
+ switch (action) {
+ case wm::WmUserMetricsAction::DRAG_MAXIMIZE_LEFT:
+ base::RecordAction(base::UserMetricsAction("WindowDrag_MaximizeLeft"));
+ break;
+ case wm::WmUserMetricsAction::DRAG_MAXIMIZE_RIGHT:
+ base::RecordAction(base::UserMetricsAction("WindowDrag_MaximizeRight"));
+ break;
+ }
+}
+
void UserMetricsRecorder::OnShellInitialized() {
// Lazy creation of the DesktopTaskSwitchMetricRecorder because it accesses
// Shell::GetInstance() which is not available when |this| is instantiated.

Powered by Google App Engine
This is Rietveld 408576698