Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1929023002: Refactors WindowResizers to use ash/wm/common (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactors WindowResizers to use ash/wm/common And some support classes that need to be moved to common as well. BUG=603369 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a Cr-Commit-Position: refs/heads/master@{#390551}

Patch Set 1 #

Total comments: 1

Patch Set 2 : move forward declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -168 lines) Patch
M ash/ash.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/metrics/user_metrics_recorder.h View 3 chunks +5 lines, -2 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/shelf/shelf_types.h View 1 chunk +0 lines, -11 lines 0 comments Download
M ash/shelf/shelf_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shelf/shelf_util.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/shell_window_ids.h View 4 chunks +16 lines, -3 lines 0 comments Download
M ash/system/cast/tray_cast.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/date/tray_date.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/system/overview/overview_button_tray.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M ash/system/tray/tray_image_item.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/tray/tray_item_view.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/system/tray/tray_utils.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/system/user/tray_user.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/aura/wm_globals_aura.h View 1 chunk +6 lines, -1 line 0 comments Download
M ash/wm/aura/wm_globals_aura.cc View 2 chunks +26 lines, -2 lines 0 comments Download
M ash/wm/aura/wm_shelf_aura.h View 3 chunks +14 lines, -3 lines 0 comments Download
M ash/wm/aura/wm_shelf_aura.cc View 4 chunks +34 lines, -2 lines 0 comments Download
M ash/wm/common/shelf/wm_shelf.h View 2 chunks +15 lines, -2 lines 0 comments Download
M ash/wm/common/shelf/wm_shelf_observer.h View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/common/shelf/wm_shelf_types.h View 1 chunk +13 lines, -0 lines 0 comments Download
A ash/wm/common/shelf/wm_shelf_util.h View 1 chunk +20 lines, -0 lines 0 comments Download
A + ash/wm/common/shelf/wm_shelf_util.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ash/wm/common/wm_globals.h View 1 3 chunks +18 lines, -2 lines 0 comments Download
M ash/wm/common/wm_shell_window_ids.h View 2 chunks +6 lines, -0 lines 0 comments Download
A + ash/wm/common/wm_user_metrics_action.h View 1 chunk +8 lines, -3 lines 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 7 chunks +8 lines, -11 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 15 chunks +35 lines, -56 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sky
4 years, 7 months ago (2016-04-28 15:45:44 UTC) #1
James Cook
LGTM https://codereview.chromium.org/1929023002/diff/1/ash/wm/common/wm_globals.h File ash/wm/common/wm_globals.h (right): https://codereview.chromium.org/1929023002/diff/1/ash/wm/common/wm_globals.h#newcode28 ash/wm/common/wm_globals.h:28: enum class WmUserMetricsAction; nit: either top of the ...
4 years, 7 months ago (2016-04-28 20:09:28 UTC) #2
sky
On 2016/04/28 20:09:28, James Cook wrote: > LGTM > > https://codereview.chromium.org/1929023002/diff/1/ash/wm/common/wm_globals.h > File ash/wm/common/wm_globals.h (right): ...
4 years, 7 months ago (2016-04-28 23:29:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929023002/20001
4 years, 7 months ago (2016-04-28 23:30:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 01:15:49 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:23:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a
Cr-Commit-Position: refs/heads/master@{#390551}

Powered by Google App Engine
This is Rietveld 408576698