LayoutTests/fast/runin/run-in-sibling-inline-block.html - Issue 19290002: Move runin to original position when sibling element is destroyed. Additionally, if If moveRunInUnd…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/runin/run-in-sibling-inline-block.html

Issue 19290002: Move runin to original position when sibling element is destroyed. Additionally, if If moveRunInUnd… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased patch Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <style>
	Julien - ping for review 2013/07/23 21:40:12 The test is missing a DOCTYPE (or do we really n The test is missing a DOCTYPE (or do we really need it to run in quirks mode?)
	2 .inlineBlock { display: inline-block; }

	3 .runin { display: run-in; }

	4 </style>

	5 <script>

	6 if (window.testRunner)

	7 testRunner.dumpAsText();

	8 var figure;

	9 var fieldSet;
	Julien - ping for review 2013/07/23 21:40:12 We don't need to define these variables here as yo We don't need to define these variables here as you only use them inside the function below.
	10 function boom() {

	11 figure = document.createElement('figure');

	12 figure.setAttribute('class', 'runin');

	13 document.documentElement.appendChild(figure);

	14 fieldSet = document.createElement('fieldset');

	15 document.documentElement.appendChild(fieldSet);

	16 document.body.offsetTop;

	17 fieldSet.setAttribute('class', 'inlineBlock');

	18 }

	19 window.onload = boom;

	20 </script>

	21 <div>

	22 PASS if test does not crash.
	Julien - ping for review 2013/07/23 21:40:12 Instructions should be complete English sentences: Instructions should be complete English sentences: This test has PASSED if it did not crash.
	23 </div>

	24

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/runin/run-in-sibling-inline-block-expected.txt » ('j') | no next file with comments »