xfa/fwl/lightwidget/cfwl_widget.cpp - Issue 1928963004: Cleanup IFWL_Adapter interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/lightwidget/cfwl_widget.cpp

Issue 1928963004: Cleanup IFWL_Adapter interfaces. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase to master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/lightwidget/cfwl_widget.cpp

diff --git a/xfa/fwl/lightwidget/cfwl_widget.cpp b/xfa/fwl/lightwidget/cfwl_widget.cpp

index 98a5a22f4398c91ba1937a17d8547ea052d783ea..078a8bf7b36b5b8d6115855ed5754e4ad67b5890 100644

--- a/xfa/fwl/lightwidget/cfwl_widget.cpp

+++ b/xfa/fwl/lightwidget/cfwl_widget.cpp

@@ -126,10 +126,10 @@ uint32_t CFWL_Widget::GetStates() {

return m_pIface->GetStates();

}

-FWL_ERR CFWL_Widget::SetStates(uint32_t dwStates, FX_BOOL bSet) {

+void CFWL_Widget::SetStates(uint32_t dwStates, FX_BOOL bSet) {

if (!m_pIface)

Tom Sepez 2016/04/28 23:40:32 nit: maybe just if (m_pIface) m_pIface->SetStat

dsinclair 2016/05/02 13:43:30 Done.

- return FWL_ERR_Indefinite;

- return m_pIface->SetStates(dwStates, bSet);

+ return;

+ m_pIface->SetStates(dwStates, bSet);

}

FWL_ERR CFWL_Widget::SetPrivateData(void* module_id,

« no previous file with comments | « xfa/fwl/lightwidget/cfwl_widget.h ('k') | xfa/fxfa/app/xfa_ffapp.cpp » ('j') | no next file with comments »