Cleanup IFWL_Adapter interfaces.

xfa/fwl/basewidget/fwl_caretimp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/basewidget/fwl_caretimp.h"
 
 #include "xfa/fwl/basewidget/ifwl_caret.h"
 #include "xfa/fwl/core/cfwl_themebackground.h"
 #include "xfa/fwl/core/fwl_noteimp.h"
 #include "xfa/fwl/core/fwl_widgetimp.h"
 #include "xfa/fwl/core/ifwl_themeprovider.h"
 
 // static
 IFWL_Caret* IFWL_Caret::Create(const CFWL_WidgetImpProperties& properties,
                                IFWL_Widget* pOuter) {
   IFWL_Caret* pCaret = new IFWL_Caret;
   CFWL_CaretImp* pCaretImpl = new CFWL_CaretImp(properties, pOuter);
   pCaret->SetImpl(pCaretImpl);
   pCaretImpl->SetInterface(pCaret);
   return pCaret;
 }
 IFWL_Caret::IFWL_Caret() {}
-FWL_ERR IFWL_Caret::ShowCaret(FX_BOOL bFlag) {
-  return static_cast<CFWL_CaretImp*>(GetImpl())->ShowCaret(bFlag);
+void IFWL_Caret::ShowCaret(FX_BOOL bFlag) {
+  static_cast<CFWL_CaretImp*>(GetImpl())->ShowCaret(bFlag);
 }
 FWL_ERR IFWL_Caret::GetFrequency(uint32_t& elapse) {
   return static_cast<CFWL_CaretImp*>(GetImpl())->GetFrequency(elapse);
 }
 FWL_ERR IFWL_Caret::SetFrequency(uint32_t elapse) {
   return static_cast<CFWL_CaretImp*>(GetImpl())->SetFrequency(elapse);
 }
 FWL_ERR IFWL_Caret::SetColor(CFX_Color crFill) {
   return static_cast<CFWL_CaretImp*>(GetImpl())->SetColor(crFill);
 }
@@ skipping 39 matching lines @@
                                   const CFX_Matrix* pMatrix) {
   if (!pGraphics)
     return FWL_ERR_Indefinite;
   if (!m_pProperties->m_pThemeProvider)
     m_pProperties->m_pThemeProvider = GetAvailableTheme();
   if (!m_pProperties->m_pThemeProvider)
     return FWL_ERR_Indefinite;
   DrawCaretBK(pGraphics, m_pProperties->m_pThemeProvider, pMatrix);
   return FWL_ERR_Succeeded;
 }
-FWL_ERR CFWL_CaretImp::ShowCaret(FX_BOOL bFlag) {
+
+void CFWL_CaretImp::ShowCaret(FX_BOOL bFlag) {
   if (m_hTimer) {
     FWL_StopTimer(m_hTimer);
-    m_hTimer = NULL;
+    m_hTimer = nullptr;
   }
-  if (bFlag) {
+  if (bFlag)
     m_hTimer = FWL_StartTimer(m_pTimer, m_dwElapse);
-  }
-  return SetStates(FWL_WGTSTATE_Invisible, !bFlag);
+
+  SetStates(FWL_WGTSTATE_Invisible, !bFlag);
 }
 FWL_ERR CFWL_CaretImp::GetFrequency(uint32_t& elapse) {
   elapse = m_dwElapse;
   return FWL_ERR_Succeeded;
 }
 FWL_ERR CFWL_CaretImp::SetFrequency(uint32_t elapse) {
   m_dwElapse = elapse;
   return FWL_ERR_Succeeded;
 }
 FWL_ERR CFWL_CaretImp::SetColor(CFX_Color crFill) {
@@ skipping 43 matching lines @@
 }
 CFWL_CaretImpDelegate::CFWL_CaretImpDelegate(CFWL_CaretImp* pOwner)
     : m_pOwner(pOwner) {}
 int32_t CFWL_CaretImpDelegate::OnProcessMessage(CFWL_Message* pMessage) {
   return 1;
 }
 FWL_ERR CFWL_CaretImpDelegate::OnDrawWidget(CFX_Graphics* pGraphics,
                                             const CFX_Matrix* pMatrix) {
   return m_pOwner->DrawWidget(pGraphics, pMatrix);
 }