Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1928943002: [debugger] account for script source offsets in --print-break-location. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] account for script source offsets in --print-break-location. R=vogelheim@chromium.org Committed: https://crrev.com/c1c53a7d4cfaeb813be500ecb8db505650bbed61 Cr-Commit-Position: refs/heads/master@{#35870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/debug/debug.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 7 months ago (2016-04-28 13:16:09 UTC) #1
vogelheim
lgtm
4 years, 7 months ago (2016-04-28 13:56:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928943002/1
4 years, 7 months ago (2016-04-28 13:59:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 14:23:52 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:40 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c1c53a7d4cfaeb813be500ecb8db505650bbed61
Cr-Commit-Position: refs/heads/master@{#35870}

Powered by Google App Engine
This is Rietveld 408576698