[wasm] Generated the framework in wasm-module for parallel compilation.

[wasm] Generated the framework in wasm-module for parallel compilation.

I introduced a new flag, --wasm-parallel-compilation, which turns on
parallel compilation of wasm modules. If parallel compilation is turned
on, then the compilation of wasm functions is split into three phases,
initialization, execution, and finalization. The execution phase is the
phase which is going to contain all the code that can be executed in
parallel. At the moment the execution phase is still empty.

R=titzer@chromium.org

Committed: https://crrev.com/e51323de5c6cf20c1153c2afc097867d9a8a8649
Cr-Commit-Position: refs/heads/master@{#35875}

[titzer, 2016-04-28 13:09:48]

https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:3043: // TODO(ahaas): Find a better way to
deallocate the WasmCompilationUnit.
I think you can drop this TODO. The pattern here is pretty standard. Create
allocates a new one and Finish destroys it.

https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.h (right):

https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.h:56: WasmCompilationUnit* CreateWasmCompilationUnit(
We will probably want to group multiple adjacent functions into the same
compilation unit (especially when there are thousands of tiny functions). So the
design of the WasmCompilationUnit should probably support multiple functions.

[ahaas, 2016-04-28 14:56:31]

https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:3043: // TODO(ahaas): Find a better way to
deallocate the WasmCompilationUnit.
On 2016/04/28 at 13:09:47, titzer wrote:
> I think you can drop this TODO. The pattern here is pretty standard. Create
allocates a new one and Finish destroys it.

Done.

https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.h (right):

https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.h:56: WasmCompilationUnit* CreateWasmCompilationUnit(
On 2016/04/28 at 13:09:47, titzer wrote:
> We will probably want to group multiple adjacent functions into the same
compilation unit (especially when there are thousands of tiny functions). So the
design of the WasmCompilationUnit should probably support multiple functions.

My plan was that a background task fetches several WasmCompilationUnits at a
time and then processes them. Thereby we get a good load balancing without
introducing to much contention on the working queue.

Aside from that the plan is that a WasmCompilationUnit contains all data needed
to compile a single function. If we want to create work packages which contain
multiple functions, then I would create another class for that. Should I rename
this class to make its purpose more obvious?

[titzer, 2016-04-28 15:25:32]

On 2016/04/28 14:56:31, ahaas wrote:
>
https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
> File src/compiler/wasm-compiler.cc (right):
> 
>
https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
> src/compiler/wasm-compiler.cc:3043: // TODO(ahaas): Find a better way to
> deallocate the WasmCompilationUnit.
> On 2016/04/28 at 13:09:47, titzer wrote:
> > I think you can drop this TODO. The pattern here is pretty standard. Create
> allocates a new one and Finish destroys it.
> 
> Done.
> 
>
https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
> File src/compiler/wasm-compiler.h (right):
> 
>
https://codereview.chromium.org/1928933002/diff/20001/src/compiler/wasm-compi...
> src/compiler/wasm-compiler.h:56: WasmCompilationUnit*
CreateWasmCompilationUnit(
> On 2016/04/28 at 13:09:47, titzer wrote:
> > We will probably want to group multiple adjacent functions into the same
> compilation unit (especially when there are thousands of tiny functions). So
the
> design of the WasmCompilationUnit should probably support multiple functions.
> 
> My plan was that a background task fetches several WasmCompilationUnits at a
> time and then processes them. Thereby we get a good load balancing without
> introducing to much contention on the working queue.
> 
> Aside from that the plan is that a WasmCompilationUnit contains all data
needed
> to compile a single function. If we want to create work packages which contain
> multiple functions, then I would create another class for that. Should I
rename
> this class to make its purpose more obvious?

Ok. After the in-person discussion and the chunking experiment, I think this is
fine, and the name CompilationUnit is fine, too. It's all fine.

LGTM

[ahaas, 2016-04-28 16:37:51]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-04-28 16:37:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928933002/40001

[commit-bot: I haz the power, 2016-04-28 16:40:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-01 22:02:50]

Description was changed from

==========
[wasm] Generated the framework in wasm-module for parallel compilation.

I introduced a new flag, --wasm-parallel-compilation, which turns on
parallel compilation of wasm modules. If parallel compilation is turned
on, then the compilation of wasm functions is split into three phases,
initialization, execution, and finalization. The execution phase is the
phase which is going to contain all the code that can be executed in
parallel. At the moment the execution phase is still empty.

R=titzer@chromium.org
==========

to

==========
[wasm] Generated the framework in wasm-module for parallel compilation.

I introduced a new flag, --wasm-parallel-compilation, which turns on
parallel compilation of wasm modules. If parallel compilation is turned
on, then the compilation of wasm functions is split into three phases,
initialization, execution, and finalization. The execution phase is the
phase which is going to contain all the code that can be executed in
parallel. At the moment the execution phase is still empty.

R=titzer@chromium.org

Committed: https://crrev.com/e51323de5c6cf20c1153c2afc097867d9a8a8649
Cr-Commit-Position: refs/heads/master@{#35875}
==========

[commit-bot: I haz the power, 2016-05-01 22:02:51]

Patchset 3 (id:??) landed as
https://crrev.com/e51323de5c6cf20c1153c2afc097867d9a8a8649
Cr-Commit-Position: refs/heads/master@{#35875}