components/ntp_tiles/pref_names.h - Issue 1928913002: Create //components/ntp_tiles.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_tiles/pref_names.h

Issue 1928913002: Create //components/ntp_tiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_NTP_TILES_PREF_NAMES_H_

	6 #define COMPONENTS_NTP_TILES_PREF_NAMES_H_

	7

	8 namespace ntp_tiles {

	9 namespace prefs {

	10

	11 extern const char kNTPSuggestionsURL[];
	jochen (gone - plz use gerrit) 2016/04/28 15:46:37 this is drop the buildflag check, is that intentio this is drop the buildflag check, is that intentional? sfiera 2016/04/28 16:11:04 Sort of. In the long run it will definitely be dro Show quoted text On 2016/04/28 15:46:37, jochen wrote: > this is drop the buildflag check, is that intentional? Sort of. In the long run it will definitely be dropped, since this component will be used on all platforms. I would have kept it for the time being, except that it would introduce a dependency on //chrome.
	12 extern const char kNTPSuggestionsIsPersonal[];

	13

	14 } // namespace prefs

	15 } // namespace ntp_tiles

	16

	17 #endif // COMPONENTS_NTP_TILES_PREF_NAMES_H_

OLD	NEW