Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1928903002: [turbofan] Abort compilation when the max deoptimization table size is exceeded. (Closed)

Created:
4 years, 7 months ago by Jarin
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Abort compilation when the max deoptimization table size is exceeded. BUG=chromium:607115 LOG=n Committed: https://crrev.com/5247b2679c3dc6cdf3ceba59c563e7c35a8428b1 Cr-Commit-Position: refs/heads/master@{#35855}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Uhm, re-enable verifier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -48 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/code-generator.h View 2 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/code-generator.cc View 5 chunks +15 lines, -8 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 4 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please? As discussed offline, I have not added the test ...
4 years, 7 months ago (2016-04-28 10:25:57 UTC) #2
Benedikt Meurer
LGTM. https://codereview.chromium.org/1928903002/diff/1/src/compiler/verifier.cc File src/compiler/verifier.cc (right): https://codereview.chromium.org/1928903002/diff/1/src/compiler/verifier.cc#newcode1041 src/compiler/verifier.cc:1041: return; Please undo.
4 years, 7 months ago (2016-04-28 10:28:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928903002/20001
4 years, 7 months ago (2016-04-28 10:52:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 11:12:19 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5247b2679c3dc6cdf3ceba59c563e7c35a8428b1
Cr-Commit-Position: refs/heads/master@{#35855}

Powered by Google App Engine
This is Rietveld 408576698