Revert to recreating RTCVideoEncoder::Impl

content/renderer/media/rtc_video_encoder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/rtc_video_encoder.h"
 
 #include <string.h>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 368 matching lines @@
     video_encoder_->RequestEncodingParametersChange(bitrate * 1000, framerate);
 }
 
 void RTCVideoEncoder::Impl::Destroy(base::WaitableEvent* async_waiter) {
   DVLOG(3) << "Impl::Destroy()";
   DCHECK(thread_checker_.CalledOnValidThread());
   if (video_encoder_) {
     video_encoder_.reset();
     SetStatus(WEBRTC_VIDEO_CODEC_UNINITIALIZED);
   }
+  input_buffers_.clear();

[Pawel Osciak, 2016/04/28 02:05:33]

What would you think of having a Clear() (or a similar) method instead?

We could call it from here and the constructor. This is specifically for
picture_id_ as it's not obvious what it should be initialized to and it'd be
best to always init uniformly...

[emircan, 2016/04/28 02:44:09]

Done.

+  output_buffers_.clear();
+  input_buffers_free_.clear();
+  output_buffers_free_count_ = 0;
+  input_next_frame_keyframe_ = false;
+  picture_id_ = static_cast<uint16_t>(base::RandInt(0, 0x7FFF));
   async_waiter->Signal();
 }
 
 int32_t RTCVideoEncoder::Impl::GetStatus() const {
   base::AutoLock lock(status_lock_);
   return status_;
 }
 
 void RTCVideoEncoder::Impl::SetStatus(int32_t status) {
   base::AutoLock lock(status_lock_);
@@ skipping 436 matching lines @@
   UMA_HISTOGRAM_BOOLEAN("Media.RTCVideoEncoderInitEncodeSuccess",
                         init_retval == WEBRTC_VIDEO_CODEC_OK);
   if (init_retval == WEBRTC_VIDEO_CODEC_OK) {
     UMA_HISTOGRAM_ENUMERATION("Media.RTCVideoEncoderProfile",
                               profile,
                               media::VIDEO_CODEC_PROFILE_MAX + 1);
   }
 }
 
 }  // namespace content