Enable FeatureList for the GPU process.

content/common/child_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/child_process_host_impl.h"
 
 #include <limits>
 
 #include "base/atomic_sequence_num.h"
+#include "base/base_switches.h"
 #include "base/command_line.h"
+#include "base/feature_list.h"
 #include "base/files/file_path.h"
 #include "base/hash.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
+#include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/numerics/safe_math.h"
 #include "base/path_service.h"
 #include "base/process/process_metrics.h"
 #include "base/rand_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/synchronization/lock.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "build/build_config.h"
 #include "content/common/child_process_messages.h"
@@ skipping 166 matching lines @@
   // places in the code a value of 0 (rather than kInvalidUniqueID) was used as
   // an invalid value. So we retain those semantics.
   int id = g_unique_id.GetNext() + 1;
 
   CHECK_NE(0, id);
   CHECK_NE(kInvalidUniqueID, id);
 
   return id;
 }
 
+void ChildProcessHostImpl::CopyEnableDisableFeatureFlags(

[Alexei Svitkine (slow), 2016/05/03 18:59:47]

Nit: CopyFeatureAndFieldTrialFlags() since now this also doing
field_trial_states.

[erikchen, 2016/05/03 19:22:31]

Done.

+    base::CommandLine* cmd_line) {
+  std::string enabled_features;
+  std::string disabled_features;
+  base::FeatureList::GetInstance()->GetFeatureOverrides(&enabled_features,
+                                                        &disabled_features);
+  if (!enabled_features.empty())
+    cmd_line->AppendSwitchASCII(switches::kEnableFeatures, enabled_features);
+  if (!disabled_features.empty())
+    cmd_line->AppendSwitchASCII(switches::kDisableFeatures, disabled_features);
+
+  // If we run base::FieldTrials, we want to pass to their state to the
+  // child process so that it can act in accordance with each state, or record
+  // histograms relating to the base::FieldTrial states.

[Alexei Svitkine (slow), 2016/05/03 18:59:47]

Nit: I'd remove the ", or record histograms relating to the base::FieldTrial
states." part of the sentence. I think this was referring to the old
field-trial-suffixed histograms which we don't use anymore.

[erikchen, 2016/05/03 19:22:31]

Done.

+  std::string field_trial_states;
+  base::FieldTrialList::AllStatesToString(&field_trial_states);
+  if (!field_trial_states.empty()) {
+    cmd_line->AppendSwitchASCII(switches::kForceFieldTrials,
+                                field_trial_states);
+  }
+}
+
 uint64_t ChildProcessHostImpl::ChildProcessUniqueIdToTracingProcessId(
     int child_process_id) {
   // In single process mode, all the children are hosted in the same process,
   // therefore the generated memory dump guids should not be conditioned by the
   // child process id. The clients need not be aware of SPM and the conversion
   // takes care of the SPM special case while translating child process ids to
   // tracing process ids.
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kSingleProcess))
     return ChildProcessHost::kBrowserTracingProcessId;
@@ skipping 113 matching lines @@
 }
 
 void ChildProcessHostImpl::OnDeletedGpuMemoryBuffer(
     gfx::GpuMemoryBufferId id,
     const gpu::SyncToken& sync_token) {
   // Note: Nothing to do here as ownership of shared memory backed
   // GpuMemoryBuffers is passed with IPC.
 }
 
 }  // namespace content