Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: src/runtime.cc

Issue 192883005: Fix issue with getOwnPropertySymbols and hidden properties (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-350864.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5793 matching lines...) Expand 10 before | Expand all | Expand 10 after
5804 if (name_from_hidden_proto == name) { 5804 if (name_from_hidden_proto == name) {
5805 names->set(j, isolate->heap()->hidden_string()); 5805 names->set(j, isolate->heap()->hidden_string());
5806 hidden_strings++; 5806 hidden_strings++;
5807 break; 5807 break;
5808 } 5808 }
5809 } 5809 }
5810 } 5810 }
5811 } 5811 }
5812 } 5812 }
5813 next_copy_index += local_property_count[i]; 5813 next_copy_index += local_property_count[i];
5814 if (jsproto->HasHiddenProperties()) { 5814
5815 // Hidden properties only show up if the filter does not skip strings.
5816 if ((filter & STRING) == 0 && jsproto->HasHiddenProperties()) {
5815 hidden_strings++; 5817 hidden_strings++;
5816 } 5818 }
5817 if (i < length - 1) { 5819 if (i < length - 1) {
5818 jsproto = Handle<JSObject>(JSObject::cast(jsproto->GetPrototype())); 5820 jsproto = Handle<JSObject>(JSObject::cast(jsproto->GetPrototype()));
5819 } 5821 }
5820 } 5822 }
5821 5823
5822 // Filter out name of hidden properties object and 5824 // Filter out name of hidden properties object and
5823 // hidden prototype duplicates. 5825 // hidden prototype duplicates.
5824 if (hidden_strings > 0) { 5826 if (hidden_strings > 0) {
(...skipping 9144 matching lines...) Expand 10 before | Expand all | Expand 10 after
14969 // Handle last resort GC and make sure to allow future allocations 14971 // Handle last resort GC and make sure to allow future allocations
14970 // to grow the heap without causing GCs (if possible). 14972 // to grow the heap without causing GCs (if possible).
14971 isolate->counters()->gc_last_resort_from_js()->Increment(); 14973 isolate->counters()->gc_last_resort_from_js()->Increment();
14972 isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags, 14974 isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags,
14973 "Runtime::PerformGC"); 14975 "Runtime::PerformGC");
14974 } 14976 }
14975 } 14977 }
14976 14978
14977 14979
14978 } } // namespace v8::internal 14980 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-350864.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698