third_party/WebKit/Source/core/fetch/ResourceTest.cpp - Issue 1928823002: Simplifying finishing a load on Resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceTest.cpp

Issue 1928823002: Simplifying finishing a load on Resource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/ResourceTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ResourceTest.cpp

index 878f727735ce95aa14a55e2c9d2ad44c519caadb..ce5620e3d70a1ce711c0fe3fb6e5b407fb91aa3e 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/ResourceTest.cpp

@@ -103,8 +103,7 @@ TEST(ResourceTest, LockFailureNoCrash)

dataVector.append("test", 4);

resource->setResourceBuffer(SharedBuffer::adoptVector(dataVector));

- resource->setLoadFinishTime(currentTime());

- resource->finish();

+ resource->finish(currentTime());

resource->prune();

ASSERT_TRUE(resource->isPurgeable());

bool didLock = resource->lock();