third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp - Issue 1928823002: Simplifying finishing a load on Resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

Issue 1928823002: Simplifying finishing a load on Resource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

index 3d39d8737d391f68043f6776251ddd4512aa5179..cadf39329c52dd9fbeaa843ca60bb834395db5e7 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

@@ -288,7 +288,7 @@ TEST(ImageResourceTest, ReloadIfLoFi)

cachedImage->reloadIfLoFi(fetcher);

ASSERT_FALSE(cachedImage->errorOccurred());

ASSERT_FALSE(cachedImage->resourceBuffer());

- ASSERT_FALSE(cachedImage->hasImage());

+ ASSERT_TRUE(cachedImage->hasImage());

ASSERT_EQ(client.imageChangedCount(), 3);

cachedImage->responseReceived(resourceResponse, nullptr);