Issue 19288005: Factor linker flag which sets text segment into a function in SConstruct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19288005: Factor linker flag which sets text segment into a function in SConstruct (Closed)

Created:
7 years, 5 months ago by Derek Schuff

Modified:
7 years, 5 months ago

Reviewers:
Roland McGrath

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Factor linker flag which sets text segment into a function in SConstruct Also use PNaCl's -Wn flag in its counterpart RodataSwitch, which indicates that the argument should be passed to the native linker. R=mcgrathr@chromium.org BUG=none TEST=bots Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11770

Patch Set 1 #

Patch Set 2 : use --section-start .text= instead of -Ttext= #

Total comments: 1

Patch Set 3 : comment on -Wn #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -10 lines)			Patch
M	SConstruct	View	1 2	1 chunk	+22 lines, -1 line	0 comments	Download
M	src/untrusted/irt/nacl.scons	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/irt_compatibility/nacl.scons	View		1 chunk	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roland McGrath

lgtm https://codereview.chromium.org/19288005/diff/30001/SConstruct File SConstruct (right): https://codereview.chromium.org/19288005/diff/30001/SConstruct#newcode2732 SConstruct:2732: args = ','.join(['-Wn'] + args) Comment about what ...

7 years, 5 months ago (2013-07-16 18:22:37 UTC) #2

Derek Schuff

7 years, 5 months ago (2013-07-16 18:34:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r11770 (presubmit successful).

Expand Messages | Collapse Messages