Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1928763002: Cleanup IFDE_CSS interfaces. (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup IFDE_CSS interfaces. This CL removes the follwing in favour of their concrete class. * IFDE_CSSDeclaration * IFDE_CSSSelector * IFDE_CSSSyntaxParser * IFDE_CSSStyleSelector Committed: https://pdfium.googlesource.com/pdfium/+/e6ebf7af7ea94d48091be300cec84b499d3b8ae0

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -373 lines) Patch
M xfa/fde/css/fde_css.h View 21 chunks +211 lines, -227 lines 0 comments Download
M xfa/fde/css/fde_cssdeclaration.h View 1 2 chunks +19 lines, -16 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.h View 4 chunks +33 lines, -33 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.cpp View 13 chunks +26 lines, -28 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.h View 5 chunks +20 lines, -22 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.cpp View 10 chunks +15 lines, -21 lines 0 comments Download
M xfa/fde/css/fde_csssyntax.h View 2 chunks +14 lines, -12 lines 0 comments Download
M xfa/fde/css/fde_csssyntax.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 3 chunks +6 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-04-27 20:34:07 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1928763002/diff/1/xfa/fde/css/fde_cssdeclaration.h File xfa/fde/css/fde_cssdeclaration.h (right): https://codereview.chromium.org/1928763002/diff/1/xfa/fde/css/fde_cssdeclaration.h#newcode159 xfa/fde/css/fde_cssdeclaration.h:159: typedef CFX_ArrayTemplate<CFDE_CSSDeclaration*> CFDE_CSSDeclarationArray; nit: using
4 years, 7 months ago (2016-04-27 22:00:01 UTC) #3
dsinclair
https://codereview.chromium.org/1928763002/diff/1/xfa/fde/css/fde_cssdeclaration.h File xfa/fde/css/fde_cssdeclaration.h (right): https://codereview.chromium.org/1928763002/diff/1/xfa/fde/css/fde_cssdeclaration.h#newcode159 xfa/fde/css/fde_cssdeclaration.h:159: typedef CFX_ArrayTemplate<CFDE_CSSDeclaration*> CFDE_CSSDeclarationArray; On 2016/04/27 22:00:01, Tom Sepez wrote: ...
4 years, 7 months ago (2016-04-28 13:19:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928763002/20001
4 years, 7 months ago (2016-04-28 13:20:05 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 13:34:27 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/e6ebf7af7ea94d48091be300cec84b499d3b...

Powered by Google App Engine
This is Rietveld 408576698