mus/views: Call to WaitForIncomingMethodCall() can fail.

mus/views: Call to WaitForIncomingMethodCall() can fail.

If the ShellConnection never made a valid connection, then the
WaitForIncomingMethodCall() returns false, but the ipc-endpoints
may not have encountered any errors [yet].

BUG=594600
Committed: https://crrev.com/f93523a0983f155818e81610f07b0250c32488ea
Cr-Commit-Position: refs/heads/master@{#390302}

[sadrul, 2016-04-27 20:04:33]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-04-27 21:09:59]

https://codereview.chromium.org/1928733002/diff/1/ui/views/mus/screen_mus.cc
File ui/views/mus/screen_mus.cc (right):

https://codereview.chromium.org/1928733002/diff/1/ui/views/mus/screen_mus.cc#...
ui/views/mus/screen_mus.cc:105: DCHECK(display_manager_.encountered_error() ||
!success);
Isn't encountered_error set in this case?

[sadrul, 2016-04-27 21:39:24]

https://codereview.chromium.org/1928733002/diff/1/ui/views/mus/screen_mus.cc
File ui/views/mus/screen_mus.cc (right):

https://codereview.chromium.org/1928733002/diff/1/ui/views/mus/screen_mus.cc#...
ui/views/mus/screen_mus.cc:105: DCHECK(display_manager_.encountered_error() ||
!success);
On 2016/04/27 21:09:59, sky wrote:
> Isn't encountered_error set in this case?

Apparently not. (it's easy to hit this DCHECK() with
https://codereview.chromium.org/1920033005/ without this patch)

[sky, 2016-04-27 23:46:18]

Ok, LGTM

[sadrul, 2016-04-28 04:49:34]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-04-28 04:49:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928733002/1

[commit-bot: I haz the power, 2016-04-28 04:54:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:16:15]

Patchset 1 (id:??) landed as
https://crrev.com/f93523a0983f155818e81610f07b0250c32488ea
Cr-Commit-Position: refs/heads/master@{#390302}

[commit-bot: I haz the power, 2016-04-30 17:54:14]

Description was changed from

==========
mus/views: Call to WaitForIncomingMethodCall() can fail.

If the ShellConnection never made a valid connection, then the
WaitForIncomingMethodCall() returns false, but the ipc-endpoints
may not have encountered any errors [yet].

BUG=594600
==========

to

==========
mus/views: Call to WaitForIncomingMethodCall() can fail.

If the ShellConnection never made a valid connection, then the
WaitForIncomingMethodCall() returns false, but the ipc-endpoints
may not have encountered any errors [yet].

BUG=594600

Committed: https://crrev.com/f93523a0983f155818e81610f07b0250c32488ea
Cr-Commit-Position: refs/heads/master@{#390302}
==========