Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2527)

Unified Diff: courgette/encode_decode_unittest.cc

Issue 1928683002: [Courgette] ELF: Fix abs32 / rel32 ordering in ParseFile() and restrict rel32 parsing to .text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/encode_decode_unittest.cc
diff --git a/courgette/encode_decode_unittest.cc b/courgette/encode_decode_unittest.cc
index 7a7d72077bdbccfd8bb50c4d9a8c02a90b8d0a56..6c52e20e7a1bb0979a3bd6acff4328818b81abd1 100644
--- a/courgette/encode_decode_unittest.cc
+++ b/courgette/encode_decode_unittest.cc
@@ -16,12 +16,12 @@
class EncodeDecodeTest : public BaseTest {
public:
void TestAssembleToStreamDisassemble(std::string file,
- size_t expected_encoded_lenth) const;
+ size_t expected_encoded_length) const;
};
void EncodeDecodeTest::TestAssembleToStreamDisassemble(
std::string file,
- size_t expected_encoded_lenth) const {
+ size_t expected_encoded_length) const {
const void* original_buffer = file.c_str();
size_t original_length = file.length();
@@ -52,7 +52,7 @@ void EncodeDecodeTest::TestAssembleToStreamDisassemble(
const void* buffer = sink.Buffer();
size_t length = sink.Length();
- EXPECT_EQ(expected_encoded_lenth, length);
+ EXPECT_EQ(expected_encoded_length, length);
courgette::SourceStreamSet sources;
bool can_get_source_streams = sources.Init(buffer, length);
@@ -88,12 +88,12 @@ TEST_F(EncodeDecodeTest, PE64) {
TEST_F(EncodeDecodeTest, Elf_Small) {
std::string file = FileContents("elf-32-1");
- TestAssembleToStreamDisassemble(file, 136218);
+ TestAssembleToStreamDisassemble(file, 136201);
}
TEST_F(EncodeDecodeTest, Elf_HighBSS) {
std::string file = FileContents("elf-32-high-bss");
- TestAssembleToStreamDisassemble(file, 7312);
+ TestAssembleToStreamDisassemble(file, 7308);
}
TEST_F(EncodeDecodeTest, Elf_Arm) {
« courgette/disassembler_elf_32.cc ('K') | « courgette/disassembler_elf_32_x86_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698