Remove media from fnl to fix build.

Remove media from fnl to fix build.

R=kulakowski@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/3f18d24c0188f0275d3dc97704acf176ac715e83

[cdotstout, 2016-04-27 16:51:02]

cstout@chromium.org changed reviewers:
+ dalesat@chromium.org

[kulakowski, 2016-04-27 16:52:06]

kulakowski@chromium.org changed reviewers:
+ kulakowski@chromium.org

[kulakowski, 2016-04-27 16:52:07]

lgtm

[dalesat, 2016-04-27 17:02:47]

What problem does this fix?

[cdotstout, 2016-04-27 17:09:50]

On 2016/04/27 17:02:47, dalesat wrote:
> What problem does this fix?

When I run:

mojo/tools/mojob.py gn --fnl
--target-sysroot=/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/x86_64-fuchsia-linux-musl
--toolchain-prefix=/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/tools/x86_64-fuchsia-linux-musl/bin/x86_64-fuchsia-linux-musl-

I get:

ERROR at //third_party/ffmpeg/BUILD.gn:134:1: Source file not found.
source_set("ffmpeg_internal") {
^------------------------------
The target:
  //third_party/ffmpeg:ffmpeg_internal
has a source file:
  //third_party/ffmpeg/chromium/config/Chromium/fnl/x64/config.h
which was not found.
___________________
ERROR at //third_party/ffmpeg/BUILD.gn:134:1: Source file not found.
source_set("ffmpeg_internal") {
^------------------------------
The target:
  //third_party/ffmpeg:ffmpeg_internal
has a source file:
  //third_party/ffmpeg/chromium/config/Chromium/fnl/x64/libavutil/avconfig.h
which was not found.

[dalesat, 2016-04-27 17:12:18]

The waterfall is all green except an apptest problem that doesn't appear
media-related. I just ran clean builds of linux and android.

[kulakowski, 2016-04-27 17:13:11]

On 2016/04/27 17:12:18, dalesat wrote:
> The waterfall is all green except an apptest problem that doesn't appear
> media-related. I just ran clean builds of linux and android.

We don't have bots for fnl.

[dalesat, 2016-04-27 17:16:27]

On 2016/04/27 17:09:50, cdotstout wrote:
> On 2016/04/27 17:02:47, dalesat wrote:
> > What problem does this fix?
> 
> When I run:
> 
> mojo/tools/mojob.py gn --fnl
>
--target-sysroot=/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/x86_64-fuchsia-linux-musl
>
--toolchain-prefix=/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/tools/x86_64-fuchsia-linux-musl/bin/x86_64-fuchsia-linux-musl-
> 
> I get:
> 
> ERROR at //third_party/ffmpeg/BUILD.gn:134:1: Source file not found.
> source_set("ffmpeg_internal") {
> ^------------------------------
> The target:
>   //third_party/ffmpeg:ffmpeg_internal
> has a source file:
>   //third_party/ffmpeg/chromium/config/Chromium/fnl/x64/config.h
> which was not found.
> ___________________
> ERROR at //third_party/ffmpeg/BUILD.gn:134:1: Source file not found.
> source_set("ffmpeg_internal") {
> ^------------------------------
> The target:
>   //third_party/ffmpeg:ffmpeg_internal
> has a source file:
>   //third_party/ffmpeg/chromium/config/Chromium/fnl/x64/libavutil/avconfig.h
> which was not found.

Can you provide the complete command line? Please don't submit this CL. I will
upload one in a moment that will address your issue and still allow me to work.

Also, why is there no trybot that runs an --fnl build?

[dalesat, 2016-04-27 17:44:31]

This is fixed now (https://codereview.chromium.org/1924843002/). Please don't
submit this CL.

[cdotstout, 2016-04-27 17:52:53]

On 2016/04/27 17:44:31, dalesat wrote:
> This is fixed now (https://codereview.chromium.org/1924843002/). Please don't
> submit this CL.

Hmm I'm still seeing this after pulling in your change:

mojo/tools/mojob.py gn --fnl
--target-sysroot=/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/x86_64-fuchsia-linux-musl
--toolchain-prefix=/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/tools/x86_64-fuchsia-linux-musl/bin/x86_64-fuchsia-linux-musl-
Running gn 'gen' '--check' 'out/fnl_Debug' '--args=use_ozone=true is_clang=false
use_goma=true target_cpu="x64"
target_sysroot="/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/x86_64-fuchsia-linux-musl"
dcheck_always_on=false is_asan=false is_debug=true
goma_dir="/usr/local/google/home/cstout/goma" is_official_build=false
toolchain_prefix="/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/tools/x86_64-fuchsia-linux-musl/bin/x86_64-fuchsia-linux-musl-"
target_os="fnl"' ...
ERROR at //third_party/ffmpeg/BUILD.gn:134:1: Source file not found.
source_set("ffmpeg_internal") {
^------------------------------
The target:
  //third_party/ffmpeg:ffmpeg_internal
has a source file:
  //third_party/ffmpeg/chromium/config/Chromium/fnl/x64/config.h
which was not found.
___________________
ERROR at //third_party/ffmpeg/BUILD.gn:134:1: Source file not found.
source_set("ffmpeg_internal") {
^------------------------------
The target:
  //third_party/ffmpeg:ffmpeg_internal
has a source file:
  //third_party/ffmpeg/chromium/config/Chromium/fnl/x64/libavutil/avconfig.h
which was not found.

[dalesat, 2016-04-27 18:12:31]

On 2016/04/27 17:52:53, cdotstout wrote:
> On 2016/04/27 17:44:31, dalesat wrote:
> > This is fixed now (https://codereview.chromium.org/1924843002/). Please
don't
> > submit this CL.
> 
> Hmm I'm still seeing this after pulling in your change:
> 
> mojo/tools/mojob.py gn --fnl
>
--target-sysroot=/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/x86_64-fuchsia-linux-musl
>
--toolchain-prefix=/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/tools/x86_64-fuchsia-linux-musl/bin/x86_64-fuchsia-linux-musl-
> Running gn 'gen' '--check' 'out/fnl_Debug' '--args=use_ozone=true
is_clang=false
> use_goma=true target_cpu="x64"
>
target_sysroot="/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/x86_64-fuchsia-linux-musl"
> dcheck_always_on=false is_asan=false is_debug=true
> goma_dir="/usr/local/google/home/cstout/goma" is_official_build=false
>
toolchain_prefix="/usr/local/google/home/cstout/projects/fuchsia/jiri_root/out/root/tools/x86_64-fuchsia-linux-musl/bin/x86_64-fuchsia-linux-musl-"
> target_os="fnl"' ...
> ERROR at //third_party/ffmpeg/BUILD.gn:134:1: Source file not found.
> source_set("ffmpeg_internal") {
> ^------------------------------
> The target:
>   //third_party/ffmpeg:ffmpeg_internal
> has a source file:
>   //third_party/ffmpeg/chromium/config/Chromium/fnl/x64/config.h
> which was not found.
> ___________________
> ERROR at //third_party/ffmpeg/BUILD.gn:134:1: Source file not found.
> source_set("ffmpeg_internal") {
> ^------------------------------
> The target:
>   //third_party/ffmpeg:ffmpeg_internal
> has a source file:
>   //third_party/ffmpeg/chromium/config/Chromium/fnl/x64/libavutil/avconfig.h
> which was not found.

Remove ffmpeg_branding from your args.gn

[cdotstout, 2016-04-27 20:25:12]

Description was changed from

==========
Remove media from fnl to fix build.
==========

to

==========
Remove media from fnl to fix build.

R=kulakowski@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/3f18d24c0188f0275d3dc97704a...
==========

[cdotstout, 2016-04-27 20:25:13]

Committed patchset #2 (id:20001) manually as
3f18d24c0188f0275d3dc97704acf176ac715e83 (presubmit successful).