Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 1928633002: VM: Fix illegal code motion. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc
index 8accbf47b9e6747515dbd95ed29262a385c5e115..b4a5f3b227e20f2c7ae9f71a912aed4066612df2 100644
--- a/runtime/vm/flow_graph_type_propagator.cc
+++ b/runtime/vm/flow_graph_type_propagator.cc
@@ -251,17 +251,8 @@ void FlowGraphTypePropagator::VisitCheckClass(CheckClassInstr* check) {
void FlowGraphTypePropagator::VisitCheckClassId(CheckClassIdInstr* check) {
- if (!check->Dependencies().IsNone()) {
- // TODO(vegorov): If check is affected by side-effect we can still propagate
- // the type further but not the cid.
- return;
- }
-
- LoadClassIdInstr* load_cid =
- check->value()->definition()->OriginalDefinition()->AsLoadClassId();
- if (load_cid != NULL) {
- SetCid(load_cid->object()->definition(), check->cid());
- }
+ // Can't propagate the type/cid because it may cause illegal code motion and
+ // we don't track dependencies in all places via redefinitions.
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698