Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 192863004: Use outlineBox if we have an outline (Closed)

Created:
6 years, 9 months ago by Julien - ping for review
Modified:
6 years, 9 months ago
Reviewers:
dsinclair, eseidel
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., ojan, esprehn
Visibility:
Public.

Description

Use outlineBox if we have an outline Currently we decided to repaint if the outline box has moved or if we have to paint the background and our outline box has changed shape. This CL updates the code to only look at the outlineBox if we have an outline. The patch was largely done by Dan Sinclair (dsinclair@chromium.org) on https://codereview.chromium.org/187813004/. I merely generated the test expectations and added some code to avoid over-invalidating. BUG=320139 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168968

Patch Set 1 #

Patch Set 2 : Added more progressions to TestExpectations #

Patch Set 3 : Fixed Mac test (neutral change => same amount of invalidation but in one instead of 2) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -35 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/compositing/repaint/repaint-into-ancestor-after-layout-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint-on-layout-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/overflow-hide-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/repaint/overflow-show-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/repaint/scroll-in-transformed-layer-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/transform-absolute-child-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/repaint/stacked-diacritics-expected.txt View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/clipped-relative-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/float-overflow-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/float-overflow-right-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 4 chunks +8 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
Julien - ping for review
6 years, 9 months ago (2014-03-10 22:07:13 UTC) #1
eseidel
6 years, 9 months ago (2014-03-10 22:14:30 UTC) #2
eseidel
lgtm
6 years, 9 months ago (2014-03-10 22:14:37 UTC) #3
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-11 00:50:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/192863004/20001
6 years, 9 months ago (2014-03-11 00:50:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 01:34:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-11 01:34:32 UTC) #7
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-11 17:53:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/192863004/40001
6 years, 9 months ago (2014-03-11 17:53:32 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 18:23:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 18:23:05 UTC) #11
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-11 18:52:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/192863004/40001
6 years, 9 months ago (2014-03-11 18:54:05 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 20:50:02 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 20:50:03 UTC) #15
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-11 21:36:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/192863004/40001
6 years, 9 months ago (2014-03-11 21:37:20 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 21:40:59 UTC) #18
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years, 9 months ago (2014-03-11 21:41:00 UTC) #19
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-11 22:04:08 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/192863004/40001
6 years, 9 months ago (2014-03-11 22:04:49 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 01:21:54 UTC) #22
Message was sent while issue was closed. 
Change committed as 168968

Powered by Google App Engine
This is Rietveld 408576698