Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1928623002: Fix ExplicitSourceResolver's handling of missing files. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ExplicitSourceResolver's handling of missing files. This fixes generation of AST-based summaries when an import can't be resolved. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/2711410a44a9a60122ed6a73d22e664c4d335cd7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M pkg/analyzer/lib/src/generated/source.dart View 2 chunks +16 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-04-27 16:21:20 UTC) #2
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-04-27 16:36:25 UTC) #3
Paul Berry
4 years, 7 months ago (2016-04-27 16:39:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2711410a44a9a60122ed6a73d22e664c4d335cd7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698