Issue 1928613002: Simplify LogImpl a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1928613002: Simplify LogImpl a bit. (Closed)

Created:
4 years, 7 months ago by viettrungluu

Modified:
4 years, 7 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Simplify LogImpl a bit. Make it take a function to print messages, rather than a FILE*. (Note: If it gets any more complicated, LogImpl should take a delegate instead, but that seems like overkill for now.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a237e8bedcf78fbea04bad25d1afb50051e4c0ef

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -51 lines)			Patch
M	PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	services/log/log_impl.h	View	3 chunks	+12 lines, -10 lines	0 comments	Download
M	services/log/log_impl.cc	View	3 chunks	+7 lines, -11 lines	0 comments	Download
M	services/log/log_impl_unittest.cc	View	3 chunks	+14 lines, -28 lines	0 comments	Download
M	services/log/main.cc	View	2 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

viettrungluu

4 years, 7 months ago (2016-04-27 20:25:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a237e8bedcf78fbea04bad25d1afb50051e4c0ef (presubmit successful).