Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: net/dns/host_resolver_impl.cc

Issue 19286002: Remove interface probing for IPv6 support from HostResolverImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/dns/host_resolver_impl.h ('K') | « net/dns/host_resolver_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/host_resolver_impl.cc
diff --git a/net/dns/host_resolver_impl.cc b/net/dns/host_resolver_impl.cc
index 87de903fc7eca46eb295709aa60d75b3c13d9789..9404d83fdc03d266c7cecdcbdb8ad9ae9249794c 100644
--- a/net/dns/host_resolver_impl.cc
+++ b/net/dns/host_resolver_impl.cc
@@ -922,54 +922,6 @@ class HostResolverImpl::ProcTask
//-----------------------------------------------------------------------------
-// Wraps a call to TestIPv6Support to be executed on the WorkerPool as it takes
-// 40-100ms.
-// TODO(szym): Remove altogether, if IPv6ActiveProbe works.
-class HostResolverImpl::IPv6ProbeJob {
- public:
- IPv6ProbeJob(const base::WeakPtr<HostResolverImpl>& resolver, NetLog* net_log)
- : resolver_(resolver),
- net_log_(BoundNetLog::Make(net_log, NetLog::SOURCE_IPV6_PROBE_JOB)),
- result_(false, IPV6_SUPPORT_MAX, OK) {
- DCHECK(resolver.get());
- net_log_.BeginEvent(NetLog::TYPE_IPV6_PROBE_RUNNING);
- const bool kIsSlow = true;
- base::WorkerPool::PostTaskAndReply(
- FROM_HERE,
- base::Bind(&IPv6ProbeJob::DoProbe, base::Unretained(this)),
- base::Bind(&IPv6ProbeJob::OnProbeComplete, base::Owned(this)),
- kIsSlow);
- }
-
- virtual ~IPv6ProbeJob() {}
-
- private:
- // Runs on worker thread.
- void DoProbe() {
- result_ = TestIPv6Support();
- }
-
- void OnProbeComplete() {
- net_log_.EndEvent(NetLog::TYPE_IPV6_PROBE_RUNNING,
- base::Bind(&IPv6SupportResult::ToNetLogValue,
- base::Unretained(&result_)));
- if (!resolver_.get())
- return;
- resolver_->IPv6ProbeSetDefaultAddressFamily(
- result_.ipv6_supported ? ADDRESS_FAMILY_UNSPECIFIED
- : ADDRESS_FAMILY_IPV4);
- }
-
- // Used/set only on origin thread.
- base::WeakPtr<HostResolverImpl> resolver_;
-
- BoundNetLog net_log_;
-
- IPv6SupportResult result_;
-
- DISALLOW_COPY_AND_ASSIGN(IPv6ProbeJob);
-};
-
// Wraps a call to HaveOnlyLoopbackAddresses to be executed on the WorkerPool as
// it takes 40-100ms and should not block initialization.
class HostResolverImpl::LoopbackProbeJob {
@@ -2083,20 +2035,6 @@ void HostResolverImpl::RemoveJob(Job* job) {
jobs_.erase(it);
}
-void HostResolverImpl::IPv6ProbeSetDefaultAddressFamily(
- AddressFamily address_family) {
- DCHECK(address_family == ADDRESS_FAMILY_UNSPECIFIED ||
- address_family == ADDRESS_FAMILY_IPV4);
- if (!ipv6_probe_monitoring_)
- return;
- if (default_address_family_ != address_family) {
- VLOG(1) << "IPv6Probe forced AddressFamily setting to "
- << ((address_family == ADDRESS_FAMILY_UNSPECIFIED) ?
- "ADDRESS_FAMILY_UNSPECIFIED" : "ADDRESS_FAMILY_IPV4");
- }
- default_address_family_ = address_family;
-}
-
void HostResolverImpl::SetHaveOnlyLoopbackAddresses(bool result) {
if (result) {
additional_resolver_flags_ |= HOST_RESOLVER_LOOPBACK_ONLY;
@@ -2194,8 +2132,6 @@ void HostResolverImpl::OnIPAddressChanged() {
probe_weak_ptr_factory_.InvalidateWeakPtrs();
if (cache_.get())
cache_->clear();
- if (ipv6_probe_monitoring_)
- new IPv6ProbeJob(probe_weak_ptr_factory_.GetWeakPtr(), net_log_);
#if defined(OS_POSIX) && !defined(OS_MACOSX)
new LoopbackProbeJob(probe_weak_ptr_factory_.GetWeakPtr());
#endif
« net/dns/host_resolver_impl.h ('K') | « net/dns/host_resolver_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698