[turbofan] Avoid obsolete steps in FunctionTester.

[turbofan] Avoid obsolete steps in FunctionTester.

This makes sure that the testing pipeline withing the FunctionTester
class only performs AST analysis and deoptimization preparation when
graphs are generated from the AST (as opposed to from bytecode).

R=yangguo@chromium.org

Committed: https://crrev.com/98ef8a9daca024a7230ce12185956be448bc81e4
Cr-Commit-Position: refs/heads/master@{#35827}

[Michael Starzinger, 2016-04-27 12:42:14]

Description was changed from

==========
[turbofan] Avoid obsolete steps in FunctionTester.

This makes sure that the testing pipeline withing the FunctionTester
class only performs AST analysis and deoptimization preparation when
graphs are generated from the AST (as opposed to from bytecode).

R=
==========

to

==========
[turbofan] Avoid obsolete steps in FunctionTester.

This makes sure that the testing pipeline withing the FunctionTester
class only performs AST analysis and deoptimization preparation when
graphs are generated from the AST (as opposed to from bytecode).

R=yangguo@chromium.org
==========

[Michael Starzinger, 2016-04-27 12:42:14]

mstarzinger@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-04-27 13:35:36]

LGTM with comment.

https://codereview.chromium.org/1928523002/diff/1/test/cctest/compiler/functi...
File test/cctest/compiler/function-tester.h (right):

https://codereview.chromium.org/1928523002/diff/1/test/cctest/compiler/functi...
test/cctest/compiler/function-tester.h:235:
CHECK(Compiler::EnsureDeoptimizationSupport(&info));
What about this one?

[Michael Starzinger, 2016-04-27 16:09:21]

Addressed comment. Landing.

https://codereview.chromium.org/1928523002/diff/1/test/cctest/compiler/functi...
File test/cctest/compiler/function-tester.h (right):

https://codereview.chromium.org/1928523002/diff/1/test/cctest/compiler/functi...
test/cctest/compiler/function-tester.h:235:
CHECK(Compiler::EnsureDeoptimizationSupport(&info));
On 2016/04/27 13:35:36, Yang wrote:
> What about this one?

Done. This is a low-level testing function where we are not actually compiling
JavaScript source, but get the pre-built graph as an input. AFAICT neither the
AST analysis nor the deoptimization support are required here. It might be fine
to drop the steps unconditionally.

[Michael Starzinger, 2016-04-27 16:25:54]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-04-27 16:25:55]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1928523002/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-04-27 16:26:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928523002/20001

[commit-bot: I haz the power, 2016-04-27 16:29:26]

Description was changed from

==========
[turbofan] Avoid obsolete steps in FunctionTester.

This makes sure that the testing pipeline withing the FunctionTester
class only performs AST analysis and deoptimization preparation when
graphs are generated from the AST (as opposed to from bytecode).

R=yangguo@chromium.org
==========

to

==========
[turbofan] Avoid obsolete steps in FunctionTester.

This makes sure that the testing pipeline withing the FunctionTester
class only performs AST analysis and deoptimization preparation when
graphs are generated from the AST (as opposed to from bytecode).

R=yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-04-27 16:29:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-01 22:01:16]

Description was changed from

==========
[turbofan] Avoid obsolete steps in FunctionTester.

This makes sure that the testing pipeline withing the FunctionTester
class only performs AST analysis and deoptimization preparation when
graphs are generated from the AST (as opposed to from bytecode).

R=yangguo@chromium.org
==========

to

==========
[turbofan] Avoid obsolete steps in FunctionTester.

This makes sure that the testing pipeline withing the FunctionTester
class only performs AST analysis and deoptimization preparation when
graphs are generated from the AST (as opposed to from bytecode).

R=yangguo@chromium.org

Committed: https://crrev.com/98ef8a9daca024a7230ce12185956be448bc81e4
Cr-Commit-Position: refs/heads/master@{#35827}
==========

[commit-bot: I haz the power, 2016-05-01 22:01:17]

Patchset 2 (id:??) landed as
https://crrev.com/98ef8a9daca024a7230ce12185956be448bc81e4
Cr-Commit-Position: refs/heads/master@{#35827}