Ship for-in initializer deprecation

Ship for-in initializer deprecation

R=hablich@chromium.org
BUG=v8:4942
LOG=true

Committed: https://crrev.com/9e7793eaacf9962c5bf548fdabba696d2c9877de
Cr-Commit-Position: refs/heads/master@{#35868}

[Michael Hablich, 2016-04-28 12:12:01]

Description was changed from

==========
Ship for-in initializer deprecation

R=hablich@chromium.org
BUG=
==========

to

==========
Ship for-in initializer deprecation

R=hablich@chromium.org
BUG=v8:4942
==========

[Michael Hablich, 2016-04-28 12:12:45]

On 2016/04/28 12:09:51, rossberg wrote:

lgtm

[rossberg, 2016-04-28 12:13:15]

The CQ bit was checked by rossberg@chromium.org

[commit-bot: I haz the power, 2016-04-28 12:13:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928513004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928513004/1

[commit-bot: I haz the power, 2016-04-28 12:25:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 12:25:50]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14300)

[Michael Hablich, 2016-04-28 12:37:11]

Description was changed from

==========
Ship for-in initializer deprecation

R=hablich@chromium.org
BUG=v8:4942
==========

to

==========
Ship for-in initializer deprecation

R=hablich@chromium.org
BUG=v8:4942
LOG=true
==========

[Michael Hablich, 2016-04-28 12:37:16]

The CQ bit was checked by hablich@chromium.org

[commit-bot: I haz the power, 2016-04-28 12:37:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928513004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928513004/1

[commit-bot: I haz the power, 2016-04-28 12:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 12:54:17]

Try jobs failed on following builders:
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/875)
  v8_linux_arm_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[rossberg, 2016-04-28 13:02:16]

The CQ bit was checked by rossberg@chromium.org

[rossberg, 2016-04-28 13:02:16]

The patchset sent to the CQ was uploaded after l-g-t-m from hablich@chromium.org
Link to the patchset: https://codereview.chromium.org/1928513004/#ps20001
(title: "Adjust tests")

[commit-bot: I haz the power, 2016-04-28 13:02:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928513004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928513004/20001

[Michael Hablich, 2016-04-28 13:06:12]

The CQ bit was unchecked by hablich@chromium.org

[Michael Hablich, 2016-04-28 13:36:11]

The CQ bit was checked by hablich@chromium.org

[commit-bot: I haz the power, 2016-04-28 13:36:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928513004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928513004/20001

[commit-bot: I haz the power, 2016-04-28 13:38:40]

Description was changed from

==========
Ship for-in initializer deprecation

R=hablich@chromium.org
BUG=v8:4942
LOG=true
==========

to

==========
Ship for-in initializer deprecation

R=hablich@chromium.org
BUG=v8:4942
LOG=true
==========

[commit-bot: I haz the power, 2016-04-28 13:38:41]

Committed patchset #2 (id:20001)

[adamk, 2016-04-28 19:01:45]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-04-28 19:01:45]

I don't think there's good evidence that this is safe. No other stable browser
has shipped this, and the chromestatus counter keeps moving up (presumably as
Chrome 50 rolls out) to end users:

https://www.chromestatus.com/metrics/feature/timeline/popularity/1238

[Michael Hablich, 2016-04-28 19:10:20]

On 2016/04/28 19:01:45, adamk wrote:
> I don't think there's good evidence that this is safe. No other stable browser
> has shipped this, and the chromestatus counter keeps moving up (presumably as
> Chrome 50 rolls out) to end users:
> 
> https://www.chromestatus.com/metrics/feature/timeline/popularity/1238

The idea was to ship it a few days to Canary so we might also get some hard bug
reports.

[adamk, 2016-04-28 19:19:04]

On 2016/04/28 19:10:20, Hablich wrote:
> On 2016/04/28 19:01:45, adamk wrote:
> > I don't think there's good evidence that this is safe. No other stable
browser
> > has shipped this, and the chromestatus counter keeps moving up (presumably
as
> > Chrome 50 rolls out) to end users:
> > 
> > https://www.chromestatus.com/metrics/feature/timeline/popularity/1238
> 
> The idea was to ship it a few days to Canary so we might also get some hard
bug
> reports.

That would be a good thing to include in the CL description in future.

[Michael Hablich, 2016-04-28 19:53:36]

Yes, sorry for that.

[commit-bot: I haz the power, 2016-05-01 22:02:35]

Description was changed from

==========
Ship for-in initializer deprecation

R=hablich@chromium.org
BUG=v8:4942
LOG=true
==========

to

==========
Ship for-in initializer deprecation

R=hablich@chromium.org
BUG=v8:4942
LOG=true

Committed: https://crrev.com/9e7793eaacf9962c5bf548fdabba696d2c9877de
Cr-Commit-Position: refs/heads/master@{#35868}
==========

[commit-bot: I haz the power, 2016-05-01 22:02:36]

Patchset 2 (id:??) landed as
https://crrev.com/9e7793eaacf9962c5bf548fdabba696d2c9877de
Cr-Commit-Position: refs/heads/master@{#35868}