src/compiler/instruction-selector.h - Issue 1928513002: Implement UnalignedLoad and UnalignedStore in WASM using LoadByte/Shift/Or and StoreByte/Shift/And.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/instruction-selector.h

Issue 1928513002: Implement UnalignedLoad and UnalignedStore in WASM using LoadByte/Shift/Or and StoreByte/Shift/And. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address code review remarks. Add missing InstructionSelector::AlignmentRequirements for all archite… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/instruction-selector.h

diff --git a/src/compiler/instruction-selector.h b/src/compiler/instruction-selector.h

index 9c1cd4ca0c0736c6deec3931263ae1fb53b3c57e..41d1474397eda2f6098ba600809ec3d0b8e3b26b 100644

--- a/src/compiler/instruction-selector.h

+++ b/src/compiler/instruction-selector.h

@@ -139,6 +139,8 @@ class InstructionSelector final {

// TODO(sigurds) This should take a CpuFeatures argument.

static MachineOperatorBuilder::Flags SupportedMachineOperatorFlags();

+ static MachineOperatorBuilder::AlignmentRequirements AlignmentRequirements();

// ===========================================================================

// ============ Architecture-independent graph covering methods. =============

// ===========================================================================

« no previous file with comments | « src/compiler/ia32/instruction-selector-ia32.cc ('k') | src/compiler/machine-operator.h » ('j') | src/compiler/machine-operator.cc » ('J')