Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1928493002: Use url::Origin to represent security origins in MediaStream-related code. (Closed)

Created:
4 years, 7 months ago by Guido Urdaneta
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, haraken, hta - Chromium, jam, kinuko+watch, mcasas+watch+vc_chromium.org, mcasas+watch+mediastream_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, philipj_slow, posciak+watch_chromium.org, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use url::Origin to represent security origins in MediaStream-related code. BUG=607112 Committed: https://crrev.com/c6dd4461f54c7d3f4e87bc6626e4a81f4b36dba0 Cr-Commit-Position: refs/heads/master@{#390857}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -222 lines) Patch
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 8 chunks +10 lines, -17 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 1 5 chunks +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 5 chunks +18 lines, -33 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 8 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 7 chunks +16 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 19 chunks +42 lines, -49 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager_unittest.cc View 1 6 chunks +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_proxy.h View 4 chunks +8 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_proxy.cc View 4 chunks +16 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognition_manager_impl.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/common/media/media_stream_messages.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/public/browser/media_device_id.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/browser/media_device_id.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 4 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 1 5 chunks +12 lines, -18 lines 0 comments Download
M content/renderer/pepper/pepper_media_device_manager.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamTrackSourcesRequest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamTrackSourcesRequest.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamTrackSourcesRequest.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
Guido Urdaneta
palmer@chromium.org: Please review changes in IPC bbudge@chromium.org: Please review changes in content/renderer/pepper mek@chromium.org: Please review ...
4 years, 7 months ago (2016-04-27 09:57:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928493002/1
4 years, 7 months ago (2016-04-27 09:58:26 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 12:37:58 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-04-27 13:16:39 UTC) #8
bbudge
content/renderer/pepper LGTM
4 years, 7 months ago (2016-04-27 14:24:54 UTC) #9
Marijn Kruisselbrink
extensions lgtm
4 years, 7 months ago (2016-04-27 17:35:32 UTC) #10
Guido Urdaneta
mkwst@: PTAL at IPC
4 years, 7 months ago (2016-04-29 08:41:38 UTC) #12
Mike West
IPC LGTM, thanks!
4 years, 7 months ago (2016-04-30 14:32:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928493002/1
4 years, 7 months ago (2016-04-30 14:33:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/168316) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-04-30 14:35:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928493002/20001
4 years, 7 months ago (2016-04-30 15:31:44 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-30 18:00:52 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 18:04:31 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c6dd4461f54c7d3f4e87bc6626e4a81f4b36dba0
Cr-Commit-Position: refs/heads/master@{#390857}

Powered by Google App Engine
This is Rietveld 408576698