Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1928473003: DBC: Enable CpuInfo test (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M runtime/vm/cpu_dbc.h View 1 chunk +23 lines, -3 lines 0 comments Download
M runtime/vm/cpu_dbc.cc View 2 chunks +27 lines, -1 line 0 comments Download
M runtime/vm/cpuinfo_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 7 months ago (2016-04-27 18:24:23 UTC) #2
Ivan Posva
LGTM -ip
4 years, 7 months ago (2016-04-29 06:08:23 UTC) #3
zra
4 years, 7 months ago (2016-04-29 16:37:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b058141f8ec242a40f8846052d500d4595d98ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698