Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1928463002: [debugger] use object with null proto to materialize scopes. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang, kozy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] use object with null proto to materialize scopes. Otherwise property lookups would also travel up the prototype chain, which makes no sense for the debugger use case. R=bmeurer@chromium.org Committed: https://crrev.com/c47066585a888771925755c46bc667d9e068fe7d Cr-Commit-Position: refs/heads/master@{#35806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M src/debug/debug-scopes.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Yang
4 years, 7 months ago (2016-04-27 05:43:09 UTC) #2
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-04-27 05:46:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928463002/1
4 years, 7 months ago (2016-04-27 05:46:32 UTC) #5
Yang
4 years, 7 months ago (2016-04-27 05:46:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 06:07:27 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 06:09:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c47066585a888771925755c46bc667d9e068fe7d
Cr-Commit-Position: refs/heads/master@{#35806}

Powered by Google App Engine
This is Rietveld 408576698