DevTools: account for client devicePixelRatio while capturing screenshots.

DevTools: account for client devicePixelRatio while capturing screenshots.

BUG=604966
Committed: https://crrev.com/d94011da06615c62c7c20a48359c509f664099ad
Cr-Commit-Position: refs/heads/master@{#390226}

[pfeldman, 2016-04-27 05:08:06]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-04-27 18:34:24]

lgtm with comments

https://codereview.chromium.org/1928453002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js
(right):

https://codereview.chromium.org/1928453002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js:400:
canvas.width = screenRect.width * dpr;
I think we'd better get scale from the
pageImage.naturalWidth / visiblePageRect.width

https://codereview.chromium.org/1928453002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js:429:
var visiblePageRect = this._model.visiblePageRect();
.scale(dpr)

[pfeldman, 2016-04-27 21:11:48]

https://codereview.chromium.org/1928453002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js
(right):

https://codereview.chromium.org/1928453002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js:400:
canvas.width = screenRect.width * dpr;
On 2016/04/27 18:34:23, dgozman wrote:
> I think we'd better get scale from the
> pageImage.naturalWidth / visiblePageRect.width

I thought about it, but it produces wrong results if the viewport is clipped.

https://codereview.chromium.org/1928453002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js:429:
var visiblePageRect = this._model.visiblePageRect();
On 2016/04/27 18:34:23, dgozman wrote:
> .scale(dpr)

Done.

[pfeldman, 2016-04-27 21:32:41]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-04-27 21:32:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1928453002/#ps40001
(title: "review comments addressed")

[dgozman, 2016-04-27 21:32:55]

still lgtm

[commit-bot: I haz the power, 2016-04-27 21:33:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928453002/40001

[commit-bot: I haz the power, 2016-04-27 23:07:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:14:15]

Patchset 3 (id:??) landed as
https://crrev.com/d94011da06615c62c7c20a48359c509f664099ad
Cr-Commit-Position: refs/heads/master@{#390226}

[commit-bot: I haz the power, 2016-04-30 17:52:39]

Description was changed from

==========
DevTools: account for client devicePixelRatio while capturing screenshots.

BUG=604966
==========

to

==========
DevTools: account for client devicePixelRatio while capturing screenshots.

BUG=604966

Committed: https://crrev.com/d94011da06615c62c7c20a48359c509f664099ad
Cr-Commit-Position: refs/heads/master@{#390226}
==========