content/browser/service_worker/service_worker_version.cc - Issue 1928443003: service worker: Update job gets the script url when the job starts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1928443003: service worker: Update job gets the script url when the job starts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/service_worker_version.cc

diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc

index 0fbeecf147988d0c80afe54277e10b145b0345d1..d50415a2412aba28ca1a9c799d1f0c50697f9c22 100644

--- a/content/browser/service_worker/service_worker_version.cc

+++ b/content/browser/service_worker/service_worker_version.cc

@@ -305,6 +305,7 @@ ServiceWorkerVersion::ServiceWorkerVersion(

DCHECK_NE(kInvalidServiceWorkerVersionId, version_id);

DCHECK(context_);

DCHECK(registration);

+ DCHECK(script_url_.is_valid());

context_->AddLiveVersion(this);

embedded_worker_ = context_->embedded_worker_registry()->CreateWorker();

embedded_worker_->AddListener(this);

« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | no next file » | no next file with comments »