content/browser/service_worker/service_worker_register_job.h - Issue 1928443003: service worker: Update job gets the script url when the job starts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.h

Issue 1928443003: service worker: Update job gets the script url when the job starts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_job_unittest.cc ('k') | content/browser/service_worker/service_worker_register_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.h

diff --git a/content/browser/service_worker/service_worker_register_job.h b/content/browser/service_worker/service_worker_register_job.h

index 66c7822d62d219577e3883d42131c9aa4f97a2f2..455f35982095a14a8161f101c9c4d5ba1fc6c12d 100644

--- a/content/browser/service_worker/service_worker_register_job.h

+++ b/content/browser/service_worker/service_worker_register_job.h

@@ -146,7 +146,7 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,

RegistrationJobType job_type_;

const GURL pattern_;

- const GURL script_url_;

+ GURL script_url_;

std::vector<RegistrationCallback> callbacks_;

Phase phase_;

Internal internal_;