content/browser/service_worker/service_worker_job_coordinator.cc - Issue 1928443003: service worker: Update job gets the script url when the job starts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_job_coordinator.cc

Issue 1928443003: service worker: Update job gets the script url when the job starts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/service_worker_job_coordinator.cc

diff --git a/content/browser/service_worker/service_worker_job_coordinator.cc b/content/browser/service_worker/service_worker_job_coordinator.cc

index 54542b2d7153bc9dd7008134f12387787807cd53..916d7147eac0c57d462e1aea292cd9c5b81db7f3 100644

--- a/content/browser/service_worker/service_worker_job_coordinator.cc

+++ b/content/browser/service_worker/service_worker_job_coordinator.cc

@@ -133,7 +133,6 @@ void ServiceWorkerJobCoordinator::Update(

ServiceWorkerRegistration* registration,

bool force_bypass_cache) {

DCHECK(registration);

- DCHECK(registration->GetNewestVersion());

job_queues_[registration->pattern()].Push(

base::WrapUnique<ServiceWorkerRegisterJobBase>(

new ServiceWorkerRegisterJob(context_, registration,

@@ -148,7 +147,6 @@ void ServiceWorkerJobCoordinator::Update(

ServiceWorkerProviderHost* provider_host,

const ServiceWorkerRegisterJob::RegistrationCallback& callback) {

DCHECK(registration);

- DCHECK(registration->GetNewestVersion());

ServiceWorkerRegisterJob* queued_job = static_cast<ServiceWorkerRegisterJob*>(

job_queues_[registration->pattern()].Push(

base::WrapUnique<ServiceWorkerRegisterJobBase>(

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_job_unittest.cc » ('j') | no next file with comments »