Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: components/offline_pages/offline_page_model_unittest.cc

Issue 1928393003: Using separate directories based on LifetimeType. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_unittest.cc
diff --git a/components/offline_pages/offline_page_model_unittest.cc b/components/offline_pages/offline_page_model_unittest.cc
index d6a843543cbdad41188828c2daf32c9e7e536728..15ea84e83379e2e24770f28bcad8f0ee3a1d1a37 100644
--- a/components/offline_pages/offline_page_model_unittest.cc
+++ b/components/offline_pages/offline_page_model_unittest.cc
@@ -20,6 +20,7 @@
#include "base/test/test_mock_time_task_runner.h"
#include "base/thread_task_runner_handle.h"
#include "base/time/time.h"
+#include "components/offline_pages/offline_page_client_policy.h"
#include "components/offline_pages/offline_page_feature.h"
#include "components/offline_pages/offline_page_item.h"
#include "components/offline_pages/offline_page_test_archiver.h"
@@ -32,6 +33,8 @@ using DeletePageResult = offline_pages::OfflinePageModel::DeletePageResult;
using GetAllPagesResult = offline_pages::OfflinePageModel::GetAllPagesResult;
using CheckPagesExistOfflineResult =
offline_pages::OfflinePageModel::CheckPagesExistOfflineResult;
+using ArchiveDirs = offline_pages::OfflinePageModel::ArchiveDirs;
+using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;
namespace offline_pages {
@@ -141,6 +144,7 @@ class OfflinePageModelTest
private:
scoped_refptr<base::TestMockTimeTaskRunner> task_runner_;
base::ThreadTaskRunnerHandle task_runner_handle_;
+ ArchiveDirs archive_dirs_;
base::ScopedTempDir temp_dir_;
std::unique_ptr<OfflinePageModel> model_;
@@ -244,8 +248,10 @@ std::unique_ptr<OfflinePageMetadataStore> OfflinePageModelTest::BuildStore() {
std::unique_ptr<OfflinePageModel> OfflinePageModelTest::BuildModel(
std::unique_ptr<OfflinePageMetadataStore> store) {
+ archive_dirs_.insert(
+ std::make_pair(LifetimeType::TEMPORARY, temp_dir_.path()));
return std::unique_ptr<OfflinePageModel>(new OfflinePageModel(
- std::move(store), temp_dir_.path(), base::ThreadTaskRunnerHandle::Get()));
+ std::move(store), archive_dirs_, base::ThreadTaskRunnerHandle::Get()));
}
void OfflinePageModelTest::ResetModel() {
« no previous file with comments | « components/offline_pages/offline_page_model.cc ('k') | components/offline_pages/offline_page_test_archiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698