chrome/browser/android/offline_pages/test_offline_page_model_builder.cc - Issue 1928393003: Using separate directories based on LifetimeType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/test_offline_page_model_builder.cc

Issue 1928393003: Using separate directories based on LifetimeType. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils_unittest.cc ('k') | chrome/browser/net/chrome_network_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/test_offline_page_model_builder.cc

diff --git a/chrome/browser/android/offline_pages/test_offline_page_model_builder.cc b/chrome/browser/android/offline_pages/test_offline_page_model_builder.cc

index b8e10fd2468439b42d0e67f67423cb9236f5e1c2..c5ebf523788222687efb13d086a5e0e986aebfd8 100644

--- a/chrome/browser/android/offline_pages/test_offline_page_model_builder.cc

+++ b/chrome/browser/android/offline_pages/test_offline_page_model_builder.cc

@@ -14,6 +14,8 @@

#include "components/offline_pages/offline_page_test_store.h"

#include "content/public/browser/browser_context.h"

+using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;

namespace offline_pages {

std::unique_ptr<KeyedService> BuildTestOfflinePageModel(

@@ -25,7 +27,7 @@ std::unique_ptr<KeyedService> BuildTestOfflinePageModel(

new OfflinePageTestStore(task_runner));

base::FilePath archives_dir =

- context->GetPath().Append(chrome::kOfflinePageArchviesDirname);

+ context->GetPath().Append(chrome::kOfflinePageArchivesDirname);

return std::unique_ptr<KeyedService>(new OfflinePageModel(

std::move(metadata_store), archives_dir, task_runner));