Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Unified Diff: chrome/browser/android/offline_pages/offline_page_model_factory.cc

Issue 1928393003: Using separate directories based on LifetimeType. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/offline_page_model_factory.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_model_factory.cc b/chrome/browser/android/offline_pages/offline_page_model_factory.cc
index 1afa51db5098b9654405b4dddca50c7fac98168c..1a8024d7d9f2317faae8226a5024780faf11375c 100644
--- a/chrome/browser/android/offline_pages/offline_page_model_factory.cc
+++ b/chrome/browser/android/offline_pages/offline_page_model_factory.cc
@@ -14,11 +14,14 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_constants.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
+#include "components/offline_pages/offline_page_client_policy.h"
#include "components/offline_pages/offline_page_metadata_store_impl.h"
#include "components/offline_pages/offline_page_model.h"
#include "components/offline_pages/proto/offline_pages.pb.h"
#include "content/public/browser/browser_thread.h"
+using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;
+
namespace offline_pages {
OfflinePageModelFactory::OfflinePageModelFactory()
@@ -51,10 +54,16 @@ KeyedService* OfflinePageModelFactory::BuildServiceInstanceFor(
std::unique_ptr<OfflinePageMetadataStoreImpl> metadata_store(
new OfflinePageMetadataStoreImpl(background_task_runner, store_path));
- base::FilePath archives_dir =
- profile->GetPath().Append(chrome::kOfflinePageArchviesDirname);
+ base::FilePath archive_persistent =
+ profile->GetPath().Append(chrome::kOfflinePageArchivesDirname);
+
+ OfflinePageModel::ArchiveDirs archive_dirs;
+ archive_dirs.insert(
+ std::make_pair(LifetimeType::TEMPORARY, archive_persistent));
+ archive_dirs.insert(
+ std::make_pair(LifetimeType::PERSISTENT, archive_persistent));
- return new OfflinePageModel(std::move(metadata_store), archives_dir,
+ return new OfflinePageModel(std::move(metadata_store), archive_dirs,
background_task_runner);
}
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_utils_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698