Add parentheses to silence clang warning

Add parentheses to silence clang warning

crrev.com/1887033002 introuced a clang warning (see below).
This fixes it, so that breakpad can be rolled in chrome, where
warnings are always fatal.

From: https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/59031/steps/compile%20%28with%20patch%29/logs/stdio

FAILED: clang_x64/obj/breakpad/dump_syms/dwarf_cu_to_module.o
../../breakpad/src/common/dwarf_cu_to_module.cc:420:20: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (declaration_ && qualified_name || (unqualified_name && enclosing_name)) {
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ ~~
../../breakpad/src/common/dwarf_cu_to_module.cc:420:20: note: place parentheses around the '&&' expression to silence this warning
if (declaration_ && qualified_name || (unqualified_name && enclosing_name)) {
                 ^
   (                             )

R=mark@chromium.org, petrcermak@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/fcb844ee32171e2340162f1ced0e7fdcde7b2b24

[Primiano Tucci (use gerrit), 2016-04-29 11:21:22]

primiano@chromium.org changed reviewers:
+ mark@chromium.org, petrcermak@chromium.org

[petrcermak, 2016-04-29 11:22:15]

LGTM. You were about 2 minutes faster than me :-D

Thanks,
Petr

[petrcermak, 2016-04-29 11:24:11]

On 2016/04/29 11:22:15, petrcermak wrote:
> LGTM. You were about 2 minutes faster than me :-D
> 
> Thanks,
> Petr

Two things:

* Remove "BUG="
* Fix the indentation of the pasted error output. I suppose you used vim and it
added extra indentation automatically.

Thanks,
Petr

[Primiano Tucci (use gerrit), 2016-04-29 11:34:49]

Description was changed from

==========
Add parentheses to silence clang warning.

crrev.com/1887033002 introuced a clang warning (see below).
This fixes it, so that breakpad can be rolled in chrome, where
warnings are always fatal.

From:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...

FAILED: clang_x64/obj/breakpad/dump_syms/dwarf_cu_to_module.o
../../breakpad/src/common/dwarf_cu_to_module.cc:420:20: error: '&&' within '||'
[-Werror,-Wlogical-op-parentheses]
  if (declaration_ && qualified_name || (unqualified_name && enclosing_name)) {
        ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ ~~
        ../../breakpad/src/common/dwarf_cu_to_module.cc:420:20: note: place
parentheses around the '&&' expression to silence this warning
          if (declaration_ && qualified_name || (unqualified_name &&
enclosing_name)) {
                             ^
                                   (                             )

BUG=
==========

to

==========
Add parentheses to silence clang warning

crrev.com/1887033002 introuced a clang warning (see below).
This fixes it, so that breakpad can be rolled in chrome, where
warnings are always fatal.

From:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...

FAILED: clang_x64/obj/breakpad/dump_syms/dwarf_cu_to_module.o
../../breakpad/src/common/dwarf_cu_to_module.cc:420:20: error: '&&' within '||'
[-Werror,-Wlogical-op-parentheses]
if (declaration_ && qualified_name || (unqualified_name && enclosing_name)) {
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ ~~
../../breakpad/src/common/dwarf_cu_to_module.cc:420:20: note: place parentheses
around the '&&' expression to silence this warning
if (declaration_ && qualified_name || (unqualified_name && enclosing_name)) {
                 ^
   (                             )
==========

[petrcermak, 2016-05-03 14:25:00]

mark: Ping

[Mark Mentovai, 2016-05-03 14:44:45]

LGTM

[Primiano Tucci (use gerrit), 2016-05-03 14:56:11]

Description was changed from

==========
Add parentheses to silence clang warning

crrev.com/1887033002 introuced a clang warning (see below).
This fixes it, so that breakpad can be rolled in chrome, where
warnings are always fatal.

From:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...

FAILED: clang_x64/obj/breakpad/dump_syms/dwarf_cu_to_module.o
../../breakpad/src/common/dwarf_cu_to_module.cc:420:20: error: '&&' within '||'
[-Werror,-Wlogical-op-parentheses]
if (declaration_ && qualified_name || (unqualified_name && enclosing_name)) {
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ ~~
../../breakpad/src/common/dwarf_cu_to_module.cc:420:20: note: place parentheses
around the '&&' expression to silence this warning
if (declaration_ && qualified_name || (unqualified_name && enclosing_name)) {
                 ^
   (                             )
==========

to

==========
Add parentheses to silence clang warning

crrev.com/1887033002 introuced a clang warning (see below).
This fixes it, so that breakpad can be rolled in chrome, where
warnings are always fatal.

From:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...

FAILED: clang_x64/obj/breakpad/dump_syms/dwarf_cu_to_module.o
../../breakpad/src/common/dwarf_cu_to_module.cc:420:20: error: '&&' within '||'
[-Werror,-Wlogical-op-parentheses]
if (declaration_ && qualified_name || (unqualified_name && enclosing_name)) {
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ ~~
../../breakpad/src/common/dwarf_cu_to_module.cc:420:20: note: place parentheses
around the '&&' expression to silence this warning
if (declaration_ && qualified_name || (unqualified_name && enclosing_name)) {
                 ^
   (                             )

R=mark@chromium.org, petrcermak@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/fcb844ee32171e2340162f1...
==========

[Primiano Tucci (use gerrit), 2016-05-03 14:56:13]

Committed patchset #1 (id:1) manually as
fcb844ee32171e2340162f1ced0e7fdcde7b2b24 (presubmit successful).