rebaseline_server: fix reload delay when there is client/server clock skew

rebaseline_server: fix reload delay when there is client/server clock skew

Currently, if there is >10 second clock skew between client and server, the 
client will attempt to reload constantly while the server is still loading
results.

NOTREECHECKS=True
NOTRY=True

Committed: http://code.google.com/p/skia/source/detail?r=13725

[epoger, 2014-03-10 17:26:05]

Ready to review at patchset 2.

[borenet, 2014-03-10 17:51:14]

LGTM with optimizing suggestion.

https://codereview.chromium.org/192833003/diff/20001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/192833003/diff/20001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/loader.js:88: $scope.localTimeString(timeToReload /
1000);
Why not store this in a timeToReloadInSeconds variable above to avoid the
unnecessary divide?

[epoger, 2014-03-10 18:04:47]

https://codereview.chromium.org/192833003/diff/20001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/192833003/diff/20001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/loader.js:88: $scope.localTimeString(timeToReload /
1000);
On 2014/03/10 17:51:14, borenet wrote:
> Why not store this in a timeToReloadInSeconds variable above to avoid the
> unnecessary divide?

The problem with that, is that I would need to divide timeNow by 1000 when
computing it anyway.

          var timeNowMillis = new Date().getTime();
          var timeToReloadSeconds = (timeNowMillis / 1000) +
reloadDelayInSeconds;
          var timeToReloadMillis = timeToReloadSeconds * 1000;

So it's the same amount of work, but more lines and one more variable.

The "good" news is that rebaseline_server has 99 performance problems, and this
ain't one.

[epoger, 2014-03-10 18:04:53]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-03-10 18:05:04]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/192833003/20001

[commit-bot: I haz the power, 2014-03-10 18:05:18]

Change committed as 13725