Only write gyp-mac-tool when needed

Only write gyp-mac-tool when needed

The gyp-mac-tool is written every time .ninja files are regenerated.
This can cause significant overbuild. This change simply avoids writing
it (and touching its time-stamp) if nothing has changed.

The equivalent fix was done for Windows in crrev.com/1932133002

BUG=607776
Committed: https://crrev.com/0305180fdbb1b8413f1d67b2f8d4af1cb70259d7
Cr-Commit-Position: refs/heads/master@{#390983}

[brucedawson, 2016-04-29 18:15:06]

brucedawson@chromium.org changed reviewers:
+ senorblanco@chromium.org

[brucedawson, 2016-04-29 18:15:06]

Do you do Mac? I need somebody to validate this fix. I've done the minimal
testing that can be done for a Mac script on a Windows machine, but it would be
good to check that it is setting the S_IEXEC bit properly.

This fix should avoid over-build on gn builds. Details in the bug.

[Stephen White, 2016-04-29 18:17:53]

Description was changed from

==========
Only write gyp-mac-tool when needed

The gyp-mac-tool is written every time .ninja files are regenerated.
This can cause significant overbuild. This change simply avoids writing
it (and touching its time-stamp) if nothing has changed.

The equivalent fix was done for Windows in crrev.com/1932133002

BUG=607776
==========

to

==========
Only write gyp-mac-tool when needed

The gyp-mac-tool is written every time .ninja files are regenerated.
This can cause significant overbuild. This change simply avoids writing
it (and touching its time-stamp) if nothing has changed.

The equivalent fix was done for Windows in crrev.com/1932133002

BUG=607776
==========

[Stephen White, 2016-04-29 18:17:53]

senorblanco@chromium.org changed reviewers:
+ rsesek@chromium.org
- senorblanco@chromium.org

[Stephen White, 2016-04-29 18:18:13]

On 2016/04/29 18:15:06, brucedawson wrote:
> Do you do Mac? I need somebody to validate this fix. I've done the minimal
> testing that can be done for a Mac script on a Windows machine, but it would
be
> good to check that it is setting the S_IEXEC bit properly.
> 
> This fix should avoid over-build on gn builds. Details in the bug.

No, I'm not really the correct person for this. rsesek@ might be, or might know
who is.

[Robert Sesek, 2016-05-02 16:58:25]

Seems to work for me, lgtm

[brucedawson, 2016-05-02 17:03:08]

On 2016/05/02 16:58:25, Robert Sesek wrote:
> Seems to work for me, lgtm

Thanks for checking. I hope it helps as much on Mac as it does on Windows.
Landing.

[brucedawson, 2016-05-02 17:03:11]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-05-02 17:03:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928303003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928303003/1

[commit-bot: I haz the power, 2016-05-02 17:34:50]

Description was changed from

==========
Only write gyp-mac-tool when needed

The gyp-mac-tool is written every time .ninja files are regenerated.
This can cause significant overbuild. This change simply avoids writing
it (and touching its time-stamp) if nothing has changed.

The equivalent fix was done for Windows in crrev.com/1932133002

BUG=607776
==========

to

==========
Only write gyp-mac-tool when needed

The gyp-mac-tool is written every time .ninja files are regenerated.
This can cause significant overbuild. This change simply avoids writing
it (and touching its time-stamp) if nothing has changed.

The equivalent fix was done for Windows in crrev.com/1932133002

BUG=607776
==========

[commit-bot: I haz the power, 2016-05-02 17:34:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-02 17:36:48]

Description was changed from

==========
Only write gyp-mac-tool when needed

The gyp-mac-tool is written every time .ninja files are regenerated.
This can cause significant overbuild. This change simply avoids writing
it (and touching its time-stamp) if nothing has changed.

The equivalent fix was done for Windows in crrev.com/1932133002

BUG=607776
==========

to

==========
Only write gyp-mac-tool when needed

The gyp-mac-tool is written every time .ninja files are regenerated.
This can cause significant overbuild. This change simply avoids writing
it (and touching its time-stamp) if nothing has changed.

The equivalent fix was done for Windows in crrev.com/1932133002

BUG=607776

Committed: https://crrev.com/0305180fdbb1b8413f1d67b2f8d4af1cb70259d7
Cr-Commit-Position: refs/heads/master@{#390983}
==========

[commit-bot: I haz the power, 2016-05-02 17:36:49]

Patchset 1 (id:??) landed as
https://crrev.com/0305180fdbb1b8413f1d67b2f8d4af1cb70259d7
Cr-Commit-Position: refs/heads/master@{#390983}