Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1928283002: CREDENTIAL: Credentials should be submitted within a registrable domain. (Closed)

Created:
4 years, 7 months ago by Mike West
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

CREDENTIAL: Credentials should be submitted within a registrable domain. The current code checks for an exact origin match when creating a Request. That doesn't match the specification; see step 3.1 of https://w3c.github.io/webappsec-credential-management/#body-extraction. BUG=606788 Review URL: https://codereview.chromium.org/1918253002 Cr-Commit-Position: refs/heads/master@{#389858} (cherry picked from commit 6036e62ac8638c3cdfd76db5dfe44ca05c62f682) Committed: https://chromium.googlesource.com/chromium/src/+/c1bd9c0416516f3e73a659dcbce7bb17741f4ff5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch-registrabledomain.html View 1 chunk +59 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/echo-post.php View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mike West
4 years, 7 months ago (2016-04-29 08:01:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1bd9c0416516f3e73a659dcbce7bb17741f4ff5.

Powered by Google App Engine
This is Rietveld 408576698