ui/webui/resources/cr_elements/cr_search_field/cr_search_icons.html - Issue 1928243002: MD History: Only load needed paper-icon-buttons instead of whole set of icons

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/cr_search_field/cr_search_icons.html

Issue 1928243002: MD History: Only load needed paper-icon-buttons instead of whole set of icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change cr_search_field icons Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_history/history_icons.html ('K') | « ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html ('k') | ui/webui/resources/cr_elements_resources.grdp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-i conset-svg.html">

	3

	4

	5 <iron-iconset-svg size="20" name="cr-search-icons">
	tsergeant 2016/05/02 16:46:46 You could maybe make this a general shared set of You could maybe make this a general shared set of `cr-icons` for all the cr_elements? dbeam@, what do you think? michaelpg 2016/05/03 02:44:34 Yes, I'd put this in cr_elements/cr_icons.html. We Show quoted text On 2016/05/02 16:46:46, tsergeant (MTV) wrote: > You could maybe make this a general shared set of `cr-icons` for all the > cr_elements? Yes, I'd put this in cr_elements/cr_icons.html. We'll include a few other common icons. I have a CL I will put up tomorrow that does this (remote desktop is failing tonight) that you can then rebase this off of. Show quoted text > > dbeam@, what do you think? michaelpg 2016/05/05 15:04:52 This is done now, please rebase. Show quoted text On 2016/05/03 02:44:34, michaelpg wrote: > On 2016/05/02 16:46:46, tsergeant (MTV) wrote: > > You could maybe make this a general shared set of `cr-icons` for all the > > cr_elements? > > Yes, I'd put this in cr_elements/cr_icons.html. We'll include a few other common > icons. I have a CL I will put up tomorrow that does this (remote desktop is > failing tonight) that you can then rebase this off of. > > > > > dbeam@, what do you think? > This is done now, please rebase.
	6 <svg><defs>

	7 <g id="cancel"><path d="M12 2C6.47 2 2 6.47 2 12s4.47 10 10 10 10-4.47 10-10S17. 53 2 12 2zm5 13.59L15.59 17 12 13.41 8.41 17 7 15.59 10.59 12 7 8.41 8.41 7 12 1 0.59 15.59 7 17 8.41 13.41 12 17 15.59z"></path></g>

	8 <g id="search"><path d="M15.5 14h-.79l-.28-.27C15.41 12.59 16 11.11 16 9.5 16 5. 91 13.09 3 9.5 3S3 5.91 3 9.5 5.91 16 9.5 16c1.61 0 3.09-.59 4.23-1.57l.27.28v.7 9l5 4.99L20.49 19l-4.99-5zm-6 0C7.01 14 5 11.99 5 9.5S7.01 5 9.5 5 14 7.01 14 9. 5 11.99 14 9.5 14z"></path></g>

	9 </defs></svg>

	10 </iron-iconset-svg>

OLD	NEW