chrome/browser/resources/md_history/history_icons.html - Issue 1928243002: MD History: Only load needed paper-icon-buttons instead of whole set of icons

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_history/history_icons.html

Issue 1928243002: MD History: Only load needed paper-icon-buttons instead of whole set of icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/resources/md_history/history_item.html » ('j') | chrome/browser/resources/md_history/history_item.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-i conset-svg.html">

	2

	3 <iron-iconset-svg size="24" name="history-icons">
	michaelpg 2016/05/11 16:50:48 optional nit: i'm trying to start a convention of optional nit: i'm trying to start a convention of naming the file just "icons.html" and the iconset just "history", so the usage is a bit shorter: chrome://md-history/icons.html <iron-icon icon="history:star"></iron-icon> lshang 2016/05/12 04:30:26 I use cr:star so this history-icons.html is not ne Show quoted text On 2016/05/11 16:50:48, michaelpg wrote: > optional nit: i'm trying to start a convention of naming the file just > "icons.html" and the iconset just "history", so the usage is a bit shorter: > > chrome://md-history/icons.html > > <iron-icon icon="history:star"></iron-icon> > I use cr:star so this history-icons.html is not needed any more. But thanks for the kind reminding!
	4 <svg>

	5 <defs>

	6 <g id="star"><path d="M12 17.27L18.18 21l-1.64-7.03L22 9.24l-7.19-.61L12 2 9.19 8.63 2 9.24l5.46 4.73L5.82 21z"></path></g>
	michaelpg 2016/05/11 16:50:48 you can use the one in cr_elements/icons.html, jus you can use the one in cr_elements/icons.html, just make it not chromeos-only anymore lshang 2016/05/12 04:30:26 Done. Show quoted text On 2016/05/11 16:50:48, michaelpg wrote: > you can use the one in cr_elements/icons.html, just make it not chromeos-only > anymore Done.
	7 </defs>

	8 </svg>

	9 </iron-iconset-svg>

OLD	NEW