Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1928233002: Remove calls to NSClassFromString while casting NSFont via foundation_util (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to NSClassFromString while casting NSFont via foundation_util A performance bottleneck in RenderTextMac flagged calls to NSClassFromString(@"NSFont") as being surprisingly expensive. Use [NSFont class] instead. BUG=605131 Committed: https://crrev.com/8967fcb75d4fd8bfcaca2db2a8db2931a16e55ba Cr-Commit-Position: refs/heads/master@{#390589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M base/mac/foundation_util.mm View 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tapted
TBR per review in https://codereview.chromium.org/1927003004/#msg6
4 years, 7 months ago (2016-04-29 03:03:24 UTC) #2
Nico
lgtm
4 years, 7 months ago (2016-04-29 03:10:57 UTC) #3
tapted
On 2016/04/29 03:03:24, tapted wrote: > TBR per review in https://codereview.chromium.org/1927003004/#msg6 *takes off TBR* :). ...
4 years, 7 months ago (2016-04-29 03:15:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928233002/1
4 years, 7 months ago (2016-04-29 03:15:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 03:53:48 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:24:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8967fcb75d4fd8bfcaca2db2a8db2931a16e55ba
Cr-Commit-Position: refs/heads/master@{#390589}

Powered by Google App Engine
This is Rietveld 408576698