Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 192823002: [Ozone] Remove unnecessary cast to EGLNativeDisplayType (Closed)

Created:
6 years, 9 months ago by dnicoara
Modified:
6 years, 9 months ago
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

[Ozone] Remove unnecessary cast to EGLNativeDisplayType https://codereview.chromium.org/184433003/ adds the khronos headers as the first headers to be used by EGL. Since we have Ozone platform typedefs in the khronos headers the cast is not necessary. TBR=piman@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/gl/gl_surface_egl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dnicoara
PTAL
6 years, 9 months ago (2014-03-10 14:39:33 UTC) #1
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 9 months ago (2014-03-10 15:31:47 UTC) #2
vignatti (out of this project)
ah, well remembered! We need that for our implementation. LGTM. Thanks.
6 years, 9 months ago (2014-03-10 17:33:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/192823002/1
6 years, 9 months ago (2014-03-10 17:52:07 UTC) #4
piman
lgtm
6 years, 9 months ago (2014-03-10 18:11:30 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 18:34:43 UTC) #6
Message was sent while issue was closed.
Change committed as 255992

Powered by Google App Engine
This is Rietveld 408576698